-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ Improvements to hot-updater console
#46
Comments
As for the design, it's nice enough. I have a few suggestions.
|
It seems like I may have written in a way that could cause misunderstanding. When deploying, if you’re using Git, the current Git commit hash is stored alongside the database. This allows you to associate the bundle files with the corresponding commit hash. The gitUrl used in the console is solely for navigation purposes, letting you locate which commit the bundle originated from. Therefore, it doesn’t matter whether the repository is private or not—it’s purely for navigation purposes. <a
href={`${gitInfo().gitUrl}/commit/${gitInfo().gitCommitHash}`} // console.gitUrl + bundle.gitCommitHash
target="_blank"
rel="noreferrer"
class="text-xs text-muted-foreground"
>
Commit Hash: {gitInfo().gitCommitHash.slice(0, 8)}
</a> It looks like I forgot to include the You can visit below link: |
packages/react-native/src/wrap.tsxIn the function wrap we should include the props passing As the wrapped HOC do not having the props included in the final return WrappedComponent, therefore its good to include it.
| |
}; Please feel free to ask question or usecase for adding these here. Thanks |
To properly format code, you add tree backticks before and after the block of code. |
Hi @gronxb When we are planning to include the AWS Only S3 Provider with the Hot Updater library. cc @dougg0k |
console.mov
https://gronxb.github.io/hot-updater/guide/console.html
Currently, it works as described above.
It allows for:
If a comment receives a lot of upvotes, I plan to work on additional improvements based on the suggestions.
The text was updated successfully, but these errors were encountered: