[cli] CLI picks up version from MARKETING_VERSION but ideally should pick CFBundleShortVersionString

[regalstreak]

Noticed this thing where while running yarn hot-updater deploy -i, the default version shows up as the MARKETING_VERSION in project.pbxproj, ideal DX should pick it up from the Info.plist as that's picked up during updates if I'm right?

Don't know why we're not updating the MARKETING_VERSION though 🥲

[gronxb]

Great point! But I don’t have time right now, and since it’s a low priority, I’ll check it later when I have some free time.

It looks like I need to update the following code:

hot-updater/packages/hot-updater/src/utils/getDefaultTargetAppVersion.ts

Lines 32 to 63 in b0f6451

	export const getIOSVersion = async (cwd: string): Promise<string | null> => {
	const filename = await findXCodeProjectFilename(cwd);
	if (!filename) return null;
	const projectPath = path.join(cwd, "ios", filename);
	try {
	const execPromise = util.promisify(exec);
	const { stdout } = await execPromise(
	`xcodebuild -project ${projectPath} -showBuildSettings | grep MARKETING_VERSION`,
	);
	const versionMatch = stdout.match(/MARKETING_VERSION = ([\d.]+)/);
	return versionMatch?.[1] ? versionMatch[1] : null;
	} catch (error) {
	return null;
	}
	};
	export const getAndroidVersion = async (
	cwd: string,
	): Promise<string | null> => {
	const buildGradlePath = path.join(cwd, "android", "app", "build.gradle");
	try {
	const buildGradleContent = await fs.readFile(buildGradlePath, "utf8");
	const versionNameMatch = buildGradleContent.match(
	/versionName\s+"([\d.]+)"/,
	);
	return versionNameMatch?.[1] ? versionNameMatch[1] : null;
	} catch (error) {
	return null;
	}
	};