Skip to content

Commit 5a54372

Browse files
android-interop-testing : Fix lint warnings in android-interop and binder modules (#12272)
Fixes #6868
1 parent 01f2862 commit 5a54372

File tree

6 files changed

+23
-6
lines changed

6 files changed

+23
-6
lines changed

android-interop-testing/src/main/AndroidManifest.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
<uses-permission android:name="android.permission.INTERNET" />
66
<!-- For UDS -->
77
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
8-
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
8+
<uses-permission
9+
android:name="android.permission.WRITE_EXTERNAL_STORAGE"
10+
android:maxSdkVersion="28" />
911
<uses-sdk tools:overrideLibrary="io.grpc.android"/>
1012

1113
<application
@@ -16,8 +18,7 @@
1618
android:name="androidx.multidex.MultiDexApplication">
1719
<activity
1820
android:name=".TesterActivity"
19-
android:exported="true"
20-
android:label="@string/app_name" >
21+
android:exported="true">
2122
<intent-filter>
2223
<action android:name="android.intent.action.MAIN" />
2324

android-interop-testing/src/main/java/io/grpc/android/integrationtest/TesterActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ private void startTest(String testCase) {
121121
((InputMethodManager) getSystemService(Context.INPUT_METHOD_SERVICE)).hideSoftInputFromWindow(
122122
hostEdit.getWindowToken(), 0);
123123
enableButtons(false);
124-
resultText.setText("Testing...");
124+
resultText.setText(R.string.testing_message);
125125

126126
String host = hostEdit.getText().toString();
127127
String portStr = portEdit.getText().toString();

android-interop-testing/src/main/res/layout/activity_tester.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
android:layout_weight="2"
1717
android:layout_width="0dp"
1818
android:layout_height="wrap_content"
19+
android:inputType="text"
1920
android:hint="Enter Host"
2021
/>
2122
<EditText
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
<resources>
22
<string name="app_name">gRPC Integration Test</string>
3+
<string name="testing_message">Testing…</string>
34
</resources>

binder/src/main/AndroidManifest.xml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,11 @@
1-
<manifest xmlns:android="http://schemas.android.com/apk/res/android" >
2-
</manifest>
1+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
2+
3+
<queries>
4+
5+
<intent>
6+
<action android:name="android.intent.action.VIEW" />
7+
</intent>
8+
9+
</queries>
10+
11+
</manifest>

lint.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,9 @@
55
Remove after AGP upgrade.
66
-->
77
<issue id="OldTargetApi" severity="ignore" />
8+
9+
<!--
10+
Suppress temporarily 'VisibleForTests' warnings - exposed for testing purposes
11+
-->
12+
<issue id="VisibleForTests" severity="ignore" />
813
</lint>

0 commit comments

Comments
 (0)