From 8968bf828916b3dc250e85b0e22897badc1eac25 Mon Sep 17 00:00:00 2001 From: Rich Beddington Date: Fri, 30 Jul 2021 15:04:27 +0100 Subject: [PATCH] Set defaults to false for loader definitions There isn't much value in having defaults set for descriptors What's more it causes issues when using those descriptors with protobufjs Descriptors with oneofIndex: 0, cause issues when they aren't part of a oneof --- packages/proto-loader/src/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/proto-loader/src/index.ts b/packages/proto-loader/src/index.ts index 98ca97b51..75194b7a0 100644 --- a/packages/proto-loader/src/index.ts +++ b/packages/proto-loader/src/index.ts @@ -148,7 +148,7 @@ const descriptorOptions: Protobuf.IConversionOptions = { longs: String, enums: String, bytes: String, - defaults: true, + defaults: false, oneofs: true, json: true, };