Skip to content

Commit 18df293

Browse files
fix(#226): android test failure on RecoverWalletScreenGrabsTest (#130)
Move SCREENGRAB_PAPERKEY build config to debug build type The `SCREENGRAB_PAPERKEY` build configuration field, used for screengrab tests, was previously defined in both the `debug` and `screengrab` build types. This commit moves the definition solely to the `debug` build type, as the `screengrab` build type inherits from `debug` and thus already has access to this field. Additionally, unused imports were removed from `BrainwalletScreengrabApp.kt`.
1 parent 7d8dd14 commit 18df293

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

app/build.gradle.kts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ android {
7171
firebaseCrashlytics {
7272
nativeSymbolUploadEnabled = true
7373
}
74+
buildConfigField("String[]", "SCREENGRAB_PAPERKEY",
75+
"new String[] {${
76+
localProperties.getProperty("SCREENGRAB_PAPERKEY", "")
77+
.split(" ")
78+
.joinToString { "\"$it\"" }
79+
}}"
80+
)
7481
}
7582

7683
val release by getting {
@@ -125,13 +132,6 @@ android {
125132
applicationId = "ltd.grunt.brainwallet.screengrab"
126133
versionNameSuffix = "-screengrab"
127134
resValue("string", "app_name", "Brainwallet (screengrab)")
128-
buildConfigField("String[]", "SCREENGRAB_PAPERKEY",
129-
"new String[] {${
130-
localProperties.getProperty("SCREENGRAB_PAPERKEY", "")
131-
.split(" ")
132-
.joinToString { "\"$it\"" }
133-
}}"
134-
)
135135

136136
externalNativeBuild {
137137
cmake {

app/src/screengrab/kotlin/com/brainwallet/BrainwalletScreengrabApp.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
package com.brainwallet
22

33
import com.brainwallet.data.source.RemoteConfigSource
4-
import com.brainwallet.di.appModule
5-
import com.brainwallet.di.dataModule
6-
import com.brainwallet.di.viewModelModule
74
import org.koin.android.ext.koin.androidContext
85
import org.koin.android.ext.koin.androidLogger
96
import org.koin.core.context.GlobalContext.startKoin

0 commit comments

Comments
 (0)