Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 12 #192

Open
Novinyo opened this issue Mar 15, 2022 · 6 comments
Open

Angular 12 #192

Novinyo opened this issue Mar 15, 2022 · 6 comments

Comments

@Novinyo
Copy link

Novinyo commented Mar 15, 2022

This does not work with Angular version 12. I tried all your versions none is working with it

@grzegorz103
Copy link
Owner

Hi. Is there any error when you start the app?

@yousefalaqra
Copy link

yousefalaqra commented Mar 15, 2022

I'm using Angular 12 (i have no choice, I had to downgrade from13 it) anyways, I might be facing the same issue. Which is:

@grzegorz103

Error: node_modules/ngx-chess-board/lib/engine/drag/end/drag-end-processor.d.ts:1:28 - error TS2307: Cannot find module '@angular/cdk/drag-drop' or its corresponding type declarations.

1 import { CdkDragEnd } from '@angular/cdk/drag-drop';
                             ~~~~~~~~~~~~~~~~~~~~~~~~

@grzegorz103
Copy link
Owner

@yousefalaqra try please install angular cdk npm i @angular/cdk
SInce some Angular version it got deleted as i remember
Let me know if this helped

@yousefalaqra
Copy link

@grzegorz103 Yes, it works right now! thank you! I would be happy to contribute to your source code, let me know what do you need and I would be love help.

Anyways, I've checked the source and I see that the angular CDK is already installed, why do I need to install it again in my project?

@grzegorz103
Copy link
Owner

Thanks. This lib has already more things implemented than i ever planned so feel free to push anything comes to your mind :)
Angular cdk is added as peer dependency to the lib, so it isn't installed automatically with the lib. It could be added as normal dependency instead of peer, but im not sure if it is good practice to manage dependencies that way in angular

@yousefalaqra
Copy link

I think there's a performance issue that I'm considering working on it. I'll investigate it, report it, and fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants