Fix codechecker warnings

cameron1729 · cameron1729 · commit 513b13e72bff · 2022-04-07T15:13:41.000+08:00
diff --git a/classes/componentsupport/base_component.php b/classes/componentsupport/base_component.php
@@ -25,8 +25,6 @@
 
 namespace filter_imageopt\componentsupport;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * The base component class.
  *
diff --git a/classes/componentsupport/mod_page.php b/classes/componentsupport/mod_page.php
@@ -24,8 +24,6 @@
  */
 namespace filter_imageopt\componentsupport;
 
-defined('MOODLE_INTERNAL') || die;
-
 use filter_imageopt\local;
 
 /**
diff --git a/classes/componentsupport/question.php b/classes/componentsupport/question.php
@@ -24,8 +24,6 @@
  */
 namespace filter_imageopt\componentsupport;
 
-defined('MOODLE_INTERNAL') || die;
-
 use filter_imageopt\local;
 
 /**
diff --git a/classes/local.php b/classes/local.php
@@ -24,8 +24,6 @@
  */
 namespace filter_imageopt;
 
-defined('MOODLE_INTERNAL') || die();
-
 use stored_file;
 
 /**
@@ -113,7 +111,7 @@ public static function get_optimised_src(\stored_file $file, $originalsrc, $opti
         global $CFG;
         $classname = '\\filter_imageopt\\componentsupport\\'.$file->get_component();
         $optimisedsrc = null;
-        if (!self::file_is_public($file->get_contenthash()) && class_exists($classname) && method_exists($classname, 'get_optimised_src')) {
+        if (!self::file_is_public($file->get_contenthash()) && method_exists($classname, 'get_optimised_src')) {
             $optimisedsrc = $classname::get_optimised_src($file, $originalsrc);
         }
         if (empty($optimisedsrc)) {
diff --git a/db/upgrade.php b/db/upgrade.php
@@ -22,8 +22,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Filter upgrade function.
  *
diff --git a/filter.php b/filter.php
@@ -22,8 +22,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 use filter_imageopt\local;
 
 /**
diff --git a/lib.php b/lib.php
@@ -24,8 +24,6 @@
 
 use filter_imageopt\local;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Serves any files associated with the image optimiser filter
  *

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@`
`25`	`25`
`26`	`26`	`namespace filter_imageopt\componentsupport;`
`27`	`27`
`28`		`-defined('MOODLE_INTERNAL') \|\| die;`
`29`		`-`
`30`	`28`	`/**`
`31`	`29`	`* The base component class.`
`32`	`30`	`*`
Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@`
`22`	`22`	`* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later`
`23`	`23`	`*/`
`24`	`24`
`25`		`-defined('MOODLE_INTERNAL') \|\| die();`
`26`		`-`
`27`	`25`	`/**`
`28`	`26`	`* Filter upgrade function.`
`29`	`27`	`*`
Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,6 @@`
`24`	`24`
`25`	`25`	`use filter_imageopt\local;`
`26`	`26`
`27`		`-defined('MOODLE_INTERNAL') \|\| die();`
`28`		`-`
`29`	`27`	`/**`
`30`	`28`	`* Serves any files associated with the image optimiser filter`
`31`	`29`	`*`