test: set LC_COLLATE (TC-3070)

Signed-off-by: mrizzi <[email protected]>
Assisted-by: Claude Code

Author: mrizzi

common/db/src/embedded.rs

@@ -1,7 +1,6 @@
 use anyhow::Context;
 use postgresql_embedded::{PostgreSQL, Settings, VersionReq};
 use std::{
-    env,
     path::{Path, PathBuf},
     pin::Pin,
 };
@@ -25,13 +24,6 @@ pub fn default_settings() -> anyhow::Result<Settings> {
 
 /// Create a new, embedded database instance
 pub async fn create() -> anyhow::Result<(Database, PostgreSQL)> {
-    // This is required because postgresql_embedded doesn't expose initdb parameters.
-    // LC_COLLATE="C" ensures deterministic, byte-order sorting that matches Rust's string comparison,
-    // making tests portable across different system locales.
-    // This affects only the embedded test database, not production databases.
-    unsafe {
-        env::set_var("LC_COLLATE", "C");
-    }
     create_for(default_settings()?, Default::default()).await
 }
 

common/db/src/lib.rs

@@ -55,7 +55,7 @@ impl<'a> Database<'a> {
 
         db.execute(Statement::from_string(
             db.get_database_backend(),
-            format!("CREATE DATABASE \"{}\";", database.name),
+            format!("CREATE DATABASE \"{}\" WITH LC_COLLATE='C';", database.name),
         ))
         .await?;
         db.close().await?;