Merge pull request #181 from Internacionalweb/fixed-return-getcropposition

adityapatadia · web-flow · commit 39066a32de84 · 2022-05-12T16:33:20.000+05:30
Modified return type to avoid implicit float to int conversion
diff --git a/lib/ImageResize.php b/lib/ImageResize.php
@@ -740,7 +740,7 @@ public function getDestHeight()
      *
      * @param integer $expectedSize
      * @param integer $position
-     * @return float|integer
+     * @return integer
      */
     protected function getCropPosition($expectedSize, $position = self::CROPCENTER)
     {
@@ -758,7 +758,7 @@ protected function getCropPosition($expectedSize, $position = self::CROPCENTER)
             $size = $expectedSize / 4;
             break;
         }
-        return $size;
+        return (int) $size;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,7 @@ public function getDestHeight()`
`740`	`740`	`*`
`741`	`741`	`* @param integer $expectedSize`
`742`	`742`	`* @param integer $position`
`743`		`- * @return float\|integer`
	`743`	`+ * @return integer`
`744`	`744`	`*/`
`745`	`745`	`protected function getCropPosition($expectedSize, $position = self::CROPCENTER)`
`746`	`746`	`{`
`@@ -758,7 +758,7 @@ protected function getCropPosition($expectedSize, $position = self::CROPCENTER)`
`758`	`758`	`$size = $expectedSize / 4;`
`759`	`759`	`break;`
`760`	`760`	`}`
`761`		`- return $size;`
	`761`	`+ return (int) $size;`
`762`	`762`	`}`
`763`	`763`
`764`	`764`	`/**`