Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons missing "?" in Elisa #11

Open
Roboron3042 opened this issue Jun 5, 2019 · 4 comments
Open

Icons missing "?" in Elisa #11

Roboron3042 opened this issue Jun 5, 2019 · 4 comments

Comments

@Roboron3042
Copy link

First and foremost, thank you very much for cyberpunkneoning this theme, it's SUPERB. I'm enjoying it very much.

Second, I've been using it system-wide and i have found some icons are missing in Elisa music player (even some basic icons like the "song" icon I'm sure this theme has... weird).

Here is a comparative between Papirus-Dark icons and Suru++ Asprómauros icons in Elisa.

Papirus
Suru++
Papirus
Suru++

Again, thank you for your work ^.^

@gusbemacbe
Copy link
Owner

I have just fixed Oomox issue and also fixed more or less than 200 icons which did not have exactly fill="currentColor" class="ColorScheme-Text", causing them to be gone. I will test on Elisa.

@gusbemacbe
Copy link
Owner

It seems that it does not have certain icons of Elisa, I will investigate why these icons are not rendered correctly:

image

@gusbemacbe
Copy link
Owner

Strange, Suru++ Asprómauros has this icon, but not rendered correctly in Elisa:

image

@SmartFinn, is this icon name exactly favorite-genres-amarok.svg?

@gusbemacbe
Copy link
Owner

gusbemacbe commented Jun 5, 2019

Hello @SmartFinn and @Roboron3042 !

I found the icons names:

https://github.com/KDE/elisa/blob/7dbdbc31c20a467b030e8a1dc751926a43fdeffc/src/models/viewsmodel.cpp#L53-L60

I searched all these icons names in Papirus and in Suru++, all they are not present, except amarok_playcount, view-media-artist, view-media-playlist and document-open-folder.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants