Updating temperature debounce issue?

[joostthehost]

Sometimes, when I update the temperature via the Home Assistant UI, the temperature jumps back to the previous setting. It seems like there is a delay between setting the temperature and processing it (and displaying the newly set temperature).

For example, going from 16 to 19 degrees.

• Click the "+" button multiple times.
  The UI goes from 16.5 to 17.0 to 17.5 to 18.0 to 17.0.

[MathieuHd]

I noticed the same issue, it comes from an bug in the warmup4ie API wrapper.

In class Warmup4IEDevice, function set_new_temperature calls the class Warmup4IE equivalent function and uses its return value to check success before updating the device. The issue is that the class Warmup4IE function does not return anything, meaning that the device is not updated until the next polling (set to every minute).

Two different possible fixes exist.

1 - Make the class Warmup4IE function return the new temperature in case of success:

    """warmup4ie.py"""
    def _set_temperature(self, room_id, mode, temperature=None):

        ...

        _LOGGER.info("Successfully set room %s - mode to %s, temperature to %s "
                     "response from server: '%s'", room_id, mode, temperature, response.text)
        self.update_all_devices()
        return temperature

2 - Prevent the class Warmup4IEDevice function from checking completion of the change:

    """warmup4ie.py"""

    # new function definition
    def set_new_temperature(self, new_temperature):
        """set new target temperature"""
        self._warmup4ie_account.set_new_temperature(self._room_id, new_temperature)

    # instead of existing:
    def set_new_temperature(self, new_temperature):
        """set new target temperature"""
        returned_temp = self._warmup4ie_account.set_new_temperature(self._room_id, new_temperature)
        if new_temperature != returned_temp:
            _LOGGER.info("Server declined to set new target temperature "
                         "to %.1f°C", new_temperature)
            return
        self.target_temperature = returned_temp
        _LOGGER.info("Successfully set new target temperature to %.1f°C",
                     self.target_temperature)

Fix 1 feels a bit clumsy, as we overwrite the new temperature read from the device with the one we requested, although both should theoreticaly be the same if everything goes fine. Code is also a bit messier. Fix 2 on the other hand is much cleaner and keeps the actual value read from the device.

I have been going with the first solution so far, but it would be intersting to test the second one to see if it works fine. I'll do it when I have a bit of time.