Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesnot work for number of pins = 355 #9

Open
deepgi opened this issue Mar 6, 2021 · 4 comments
Open

Doesnot work for number of pins = 355 #9

deepgi opened this issue Mar 6, 2021 · 4 comments

Comments

@deepgi
Copy link

deepgi commented Mar 6, 2021

Hi,
I really like this app, its very clean and quick as I don't have to compute on my system. I started off with installing the pins on my canvas and the total comes out to be 355. Strangely the app just doesn't start computing for this number of strings. could you please look into it ?

Regards,
Deepanshu

@halfmonty
Copy link
Owner

halfmonty commented Mar 6, 2021

I just tested 355 and it was able to compute (albeit slowly) a full 4000 lines of string art. See attached.
https://imgur.com/Sl3GzUE

However, the more pins there are the more memory it requires from your browser so my hunch is that you might be hitting a memory limit? I'm using Chrome on a machine with plenty of RAM. Perhaps try a different browser from the one you are currently using. I would assume that it's throwing some sort of console error if it's not working for you. So you can try again, press F-12 on you keyboard, then go to the console tab and paste me any errors you see there. Hope this helps

@deepgi
Copy link
Author

deepgi commented Mar 6, 2021

Hi, thanks a lot for the quick reply. Please find below the error message in Chrome.

image

@halfmonty
Copy link
Owner

Ok, so I know what's going on. It's not a memory limit, it's a limit on the number of recursive loops allowed by the browser. This is to prevent infinite loops which would be a problem. However, this obviously isn't an infinite loop, it;s just such a large loop it exceeds the browser's maximum when you are using 355 pins. (Behind the scenes it's using very large arrays in order to calculate the best string per loop)

Also, I wasn't clear before, I said I was using Chrome but that's not exactly correct. I'm using Vivaldi which is based on Chromium. When I tried this on Chrome I got the same error you did. I've confirmed that it works on Vivaldi and on Firefox. If you can use one of those browsers then that should get it working much faster than I could fix the problem with Chrome.

@deepgi
Copy link
Author

deepgi commented Mar 7, 2021

I'll try it with Firefox. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants