Bump ameba and fix violations

Author: hanneskaeufler

shard.yml

@@ -18,4 +18,4 @@ scripts:
 development_dependencies:
   ameba:
     github: veelenga/ameba
-    version: 1.2.0
+    version: 1.6.1

spec/fake_file.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 class FakeFile
   @@files_deleted = [] of String
   @@tempfiles_created = [] of String

spec/fake_generator.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 require "../src/crytic/generator/generator"
 require "../src/crytic/mutation/mutation"
 

spec/fake_http_client.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 require "../src/crytic/reporter/http_client"
 require "http/server/response"
 

spec/fake_mutation.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 require "../src/crytic/mutant/bool_literal_flip"
 require "../src/crytic/mutation/mutation"
 require "../src/crytic/mutation/result"

spec/fake_process_runner.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 require "../src/crytic/process_runner"
 
 module Crytic
@@ -10,7 +11,7 @@ module Crytic
     @output_io = IO::Memory.new
 
     def cmd_with_args
-      @cmd.zip(@args).map { |c, a| "#{c} #{a}".strip }
+      @cmd.zip(@args).map { |cmd, args| "#{cmd} #{args}".strip }
     end
 
     def run(cmd : String, args : Array(String), output, error)

spec/generator/empty_source_file.cr

@@ -0,0 +1 @@
+# ameba:disable Lint/SpecFilename

spec/generator/non_empty_source_file.cr

@@ -1,3 +1,4 @@
+# ameba:disable Lint/SpecFilename
 def foo
   1
 end

spec/runner/sequential_spec.cr

@@ -54,7 +54,7 @@ private class FakeRun
   property mutations = [] of Crytic::Mutation::Mutation
   property events = [] of String
   property original_exit_code = 0
-  property final_result = true
+  property? final_result = true
   property neutral = FakeMutation.new.as(Crytic::Mutation::Mutation)
 
   def generate_mutations
@@ -70,7 +70,7 @@ private class FakeRun
   end
 
   def report_final(results)
-    final_result
+    final_result?
   end
 
   def execute_original_test_suite(side_effects)

src/crytic/diff.cr

@@ -46,7 +46,7 @@ module Crytic
         data.map(&.colorize(append? ? :green : :red).to_s)
       end
 
-      def is_last_chunk?(a_size, b_size)
+      def last_chunk?(a_size, b_size)
         delete? ? range_a.end == a_size : range_b.end == b_size
       end
     end
@@ -199,7 +199,7 @@ module Crytic
 
         add_with_prefix cur.prefix, cur.colored_data, group
 
-        if !group.last.ends_with?(newline) && cur.is_last_chunk?(a.size, b.size)
+        if !group.last.ends_with?(newline) && cur.last_chunk?(a.size, b.size)
           group[-1] += newline
           group.push "\\ No newline at end of file#{newline}"
         end

src/crytic/mutant/full_location.cr

@@ -13,32 +13,32 @@ module Crytic::Mutant
     def matches?(node : Crystal::And | Crystal::Or)
       node_location = node.location
       return false if node_location.nil?
-      return is_same(node_location, location) if name_location.nil?
+      return same?(node_location, location) if name_location.nil?
 
-      is_same(node_location, location) && is_same(node.end_location, name_location)
+      same?(node_location, location) && same?(node.end_location, name_location)
     end
 
     def matches?(node : Crystal::ASTNode)
       node_location = node.location
       return false if node_location.nil?
-      return is_same(node_location, location) if name_location.nil?
+      return same?(node_location, location) if name_location.nil?
 
-      is_same(node_location, location) && is_same(node.name_location, name_location)
+      same?(node_location, location) && same?(node.name_location, name_location)
     end
 
-    private def is_same(location : Crystal::Location, other : Crystal::Location) : Bool
+    private def same?(location : Crystal::Location, other : Crystal::Location) : Bool
       location.line_number == other.line_number && location.column_number == other.column_number
     end
 
-    private def is_same(location : Nil, other : Nil) : Bool
+    private def same?(location : Nil, other : Nil) : Bool
       false
     end
 
-    private def is_same(location : Crystal::Location, other : Nil) : Bool
+    private def same?(location : Crystal::Location, other : Nil) : Bool
       false
     end
 
-    private def is_same(location : Nil, other : Crystal::Location) : Bool
+    private def same?(location : Nil, other : Crystal::Location) : Bool
       false
     end
   end

src/crytic/mutant/number_literal_sign_flip_possibilities.cr

@@ -4,7 +4,7 @@ module Crytic::Mutant
   class NumberLiteralSignFlipPossibilities < Possibilities
     def visit(node : Crystal::NumberLiteral)
       return true if node.value == "0"
-      return true if is_unsigned_type(node)
+      return true if unsigned_type?(node)
 
       location = node.location
       unless location.nil?
@@ -13,7 +13,7 @@ module Crytic::Mutant
       true
     end
 
-    private def is_unsigned_type(node)
+    private def unsigned_type?(node)
       node.kind.to_s.starts_with?("u")
     end
   end

src/crytic/mutation/inject_mutated_subject_into_specs.cr

@@ -33,7 +33,9 @@ module Crytic::Mutation
 
         @enriched_source = unfold_required(astree.to_s)
       else
-        @enriched_source.not_nil!
+        # force unwrapping is fine here, we're in the else
+        # branch of having done the nil check
+        @enriched_source.not_nil! # ameba:disable Lint/NotNil
       end
     end
 

src/crytic/mutation/require_resolver.cr

@@ -9,7 +9,7 @@ module Crytic::Mutation
       recursive = filename.ends_with?("/**")
 
       if filename.ends_with?("/*") || recursive
-        filename_dir_index = filename.rindex('/').not_nil!
+        filename_dir_index = filename.rindex!('/')
         filename_dir = filename[0..filename_dir_index]
         relative_dir = "#{relative_to}/#{filename_dir}"
 

src/crytic/mutation/result_set.cr

@@ -26,7 +26,7 @@ module Crytic::Mutation
     end
 
     def longest_mutated_filename_length
-      @results.map(&.mutated_file.size).max? || 0
+      @results.max_of?(&.mutated_file.size) || 0
     end
   end
 end

src/crytic/mutation/tracker.cr

@@ -25,15 +25,15 @@ module Crytic::Mutation
       relative_path_to_project(File.expand_path(file.path, "."))
     end
 
-    def parse_file_at_path(file)
+    def parse_file_at_path(file, &)
       file = relative_path_to_project(file)
-      unless is_already_tracked?(file)
+      unless already_tracked?(file)
         tracked_filepaths.add(file)
         yield
       end
     end
 
-    private def is_already_tracked?(file)
+    private def already_tracked?(file)
       tracked_filepaths.includes?(file)
     end