Skip to content

Commit d50d0cd

Browse files
authored
Expand js handle ignore (#2851)
* Expand JSHandle test ignore * just me it build
1 parent 3946d92 commit d50d0cd

File tree

2 files changed

+96
-2
lines changed

2 files changed

+96
-2
lines changed

Diff for: lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

+91-1
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,97 @@
857857
},
858858
{
859859
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
860-
"testIdPattern": "[jshandle.spec] *",
860+
"testIdPattern": "[jshandle.spec] *.asElement*",
861+
"platforms": [
862+
"darwin",
863+
"linux",
864+
"win32"
865+
],
866+
"parameters": [
867+
"webDriverBiDi"
868+
],
869+
"expectations": [
870+
"FAIL"
871+
]
872+
},
873+
{
874+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
875+
"testIdPattern": "[jshandle.spec] *.clickablePoint*",
876+
"platforms": [
877+
"darwin",
878+
"linux",
879+
"win32"
880+
],
881+
"parameters": [
882+
"webDriverBiDi"
883+
],
884+
"expectations": [
885+
"FAIL"
886+
]
887+
},
888+
{
889+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
890+
"testIdPattern": "[jshandle.spec] *getProperties*",
891+
"platforms": [
892+
"darwin",
893+
"linux",
894+
"win32"
895+
],
896+
"parameters": [
897+
"webDriverBiDi"
898+
],
899+
"expectations": [
900+
"FAIL"
901+
]
902+
},
903+
{
904+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
905+
"testIdPattern": "[jshandle.spec] *.getProperty*",
906+
"platforms": [
907+
"darwin",
908+
"linux",
909+
"win32"
910+
],
911+
"parameters": [
912+
"webDriverBiDi"
913+
],
914+
"expectations": [
915+
"FAIL"
916+
]
917+
},
918+
{
919+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
920+
"testIdPattern": "[jshandle.spec] *.jsonValue*",
921+
"platforms": [
922+
"darwin",
923+
"linux",
924+
"win32"
925+
],
926+
"parameters": [
927+
"webDriverBiDi"
928+
],
929+
"expectations": [
930+
"FAIL"
931+
]
932+
},
933+
{
934+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
935+
"testIdPattern": "[jshandle.spec] *.evaluateHandle*",
936+
"platforms": [
937+
"darwin",
938+
"linux",
939+
"win32"
940+
],
941+
"parameters": [
942+
"webDriverBiDi"
943+
],
944+
"expectations": [
945+
"FAIL"
946+
]
947+
},
948+
{
949+
"comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
950+
"testIdPattern": "[jshandle.spec] *JSHandle.toString*",
861951
"platforms": [
862952
"darwin",
863953
"linux",

Diff for: lib/PuppeteerSharp/Bidi/BidiJSHandle.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,14 @@ namespace PuppeteerSharp.Bidi;
2727

2828
internal class BidiJSHandle : JSHandle
2929
{
30-
public BidiJSHandle(IsolatedWorld world, RemoteObject remoteObject) : base(world, remoteObject)
30+
public BidiJSHandle(IsolatedWorld world, RemoteObject remoteObject)
3131
{
3232
}
3333

34+
public override RemoteObject RemoteObject { get; }
35+
36+
internal override IsolatedWorld Realm { get; }
37+
3438
public override Task<T> JsonValueAsync<T>() => throw new System.NotImplementedException();
3539

3640
public override ValueTask DisposeAsync() => throw new System.NotImplementedException();

0 commit comments

Comments
 (0)