Skip to content

Commit 259fba8

Browse files
committed
[FFM-1108]: Fix the 500 error on target details page
1 parent df4e589 commit 259fba8

File tree

6 files changed

+6
-8
lines changed

6 files changed

+6
-8
lines changed

evaluation/feature.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,11 @@ func (fc FeatureConfig) GetVariationName(target *Target) string {
228228
if variationMap.TargetSegments != nil {
229229
for _, segmentIdentifier := range variationMap.TargetSegments {
230230
segment := fc.Segments[segmentIdentifier]
231-
for _, t := range segment.Included {
232-
if t == target.Identifier {
233-
return variationMap.Variation
231+
if segment.Included != nil {
232+
for _, t := range segment.Included {
233+
if t == target.Identifier {
234+
return variationMap.Variation
235+
}
234236
}
235237
}
236238
}

metricsclient/services.gen.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

metricsclient/types.gen.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test_wrapper/ffgosdk/ff_go_sdk.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88

99
harness "github.com/drone/ff-golang-server-sdk/client"
1010
"github.com/drone/ff-golang-server-sdk/evaluation"
11-
"github.com/drone/ff-golang-server-sdk/test_wrapper/wrapperconfig"
1211
"github.com/drone/ff-golang-server-sdk/test_wrapper/restapi"
12+
"github.com/drone/ff-golang-server-sdk/test_wrapper/wrapperconfig"
1313
"github.com/drone/ff-golang-server-sdk/types"
1414
)
1515

test_wrapper/restapi/test_wrapper_service.gen.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test_wrapper/restapi/test_wrapper_types.gen.go

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)