Skip to content

Commit 97d5472

Browse files
Merge pull request #113 from harness/FFM-7347-logging-improvements
(FFM-7347) Remove mkdir error log on startup
2 parents 7be22ae + 70e2445 commit 97d5472

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

client/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ type config struct {
2929

3030
func newDefaultConfig(log logger.Logger) *config {
3131
defaultCache, _ := cache.NewLruCache(10000, log) // size of cache
32-
defaultStore := storage.NewFileStore("defaultProject", storage.GetHarnessDir(), log)
32+
defaultStore := storage.NewFileStore("defaultProject", storage.GetHarnessDir(log), log)
3333

3434
retryClient := retryablehttp.NewClient()
3535
retryClient.RetryMax = 10

storage/storage.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package storage
22

33
import (
4-
"log"
54
"os"
65
"path"
76
"time"
@@ -42,17 +41,17 @@ type Storage interface {
4241
}
4342

4443
// GetHarnessDir returns home folder for harness ff server files
45-
func GetHarnessDir() string {
44+
func GetHarnessDir(logger logger.Logger) string {
4645
home, err := homedir.Dir()
4746
if err != nil {
48-
log.Printf("error while getting home dir: %v", err)
47+
logger.Warnf("error while getting home dir: %v", err)
4948
return ""
5049
}
5150
harnessDir := path.Join(home, "harness")
5251
if _, err := os.Stat(harnessDir); os.IsNotExist(err) {
5352
err := os.Mkdir(harnessDir, os.ModePerm)
5453
if err != nil {
55-
log.Println(err)
54+
logger.Warn(err)
5655
}
5756
}
5857
return harnessDir

0 commit comments

Comments
 (0)