5
5
"reflect"
6
6
"testing"
7
7
8
+ "github.com/harness/ff-golang-server-sdk/logger"
9
+
8
10
"github.com/harness/ff-golang-server-sdk/rest"
9
11
)
10
12
@@ -303,9 +305,11 @@ func (m TestRepository) GetFlag(identifier string) (rest.FeatureConfig, error) {
303
305
}
304
306
305
307
func TestNewEvaluator (t * testing.T ) {
306
- eval , _ := NewEvaluator (testRepo , nil )
308
+ noOpLogger := logger .NewNoOpLogger ()
309
+ eval , _ := NewEvaluator (testRepo , nil , noOpLogger )
307
310
type args struct {
308
- query Query
311
+ query Query
312
+ logger logger.Logger
309
313
}
310
314
tests := []struct {
311
315
name string
@@ -322,15 +326,16 @@ func TestNewEvaluator(t *testing.T) {
322
326
{
323
327
name : "should return test repo" ,
324
328
args : args {
325
- query : testRepo ,
329
+ query : testRepo ,
330
+ logger : noOpLogger ,
326
331
},
327
332
want : eval ,
328
333
wantErr : false ,
329
334
},
330
335
}
331
336
for _ , tt := range tests {
332
337
t .Run (tt .name , func (t * testing.T ) {
333
- got , err := NewEvaluator (tt .args .query , nil )
338
+ got , err := NewEvaluator (tt .args .query , nil , noOpLogger )
334
339
if (err != nil ) != tt .wantErr {
335
340
t .Errorf ("NewEvaluator() error = %v, wantErr %v" , err , tt .wantErr )
336
341
return
@@ -616,7 +621,8 @@ func TestEvaluator_evaluateClause(t *testing.T) {
616
621
for _ , tt := range tests {
617
622
t .Run (tt .name , func (t * testing.T ) {
618
623
e := Evaluator {
619
- query : tt .fields .query ,
624
+ query : tt .fields .query ,
625
+ logger : logger .NewNoOpLogger (),
620
626
}
621
627
if got := e .evaluateClause (tt .args .clause , tt .args .target ); got != tt .want {
622
628
t .Errorf ("Evaluator.evaluateClause() = %v, want %v" , got , tt .want )
@@ -797,7 +803,8 @@ func TestEvaluator_evaluateRules(t *testing.T) {
797
803
for _ , tt := range tests {
798
804
t .Run (tt .name , func (t * testing.T ) {
799
805
e := Evaluator {
800
- query : tt .fields .query ,
806
+ query : tt .fields .query ,
807
+ logger : logger .NewNoOpLogger (),
801
808
}
802
809
if got := e .evaluateRules (tt .args .servingRules , tt .args .target ); got != tt .want {
803
810
t .Errorf ("Evaluator.evaluateRules() = %v, want %v" , got , tt .want )
@@ -915,7 +922,8 @@ func TestEvaluator_evaluateVariationMap(t *testing.T) {
915
922
for _ , tt := range tests {
916
923
t .Run (tt .name , func (t * testing.T ) {
917
924
e := Evaluator {
918
- query : tt .fields .query ,
925
+ query : tt .fields .query ,
926
+ logger : logger .NewNoOpLogger (),
919
927
}
920
928
if got := e .evaluateVariationMap (tt .args .variationsMap , tt .args .target ); got != tt .want {
921
929
t .Errorf ("Evaluator.evaluateVariationMap() = %v, want %v" , got , tt .want )
@@ -1080,7 +1088,8 @@ func TestEvaluator_evaluateFlag(t *testing.T) {
1080
1088
for _ , tt := range tests {
1081
1089
t .Run (tt .name , func (t * testing.T ) {
1082
1090
e := Evaluator {
1083
- query : tt .fields .query ,
1091
+ query : tt .fields .query ,
1092
+ logger : logger .NewNoOpLogger (),
1084
1093
}
1085
1094
got , err := e .evaluateFlag (tt .args .fc , tt .args .target )
1086
1095
if (err != nil ) != tt .wantErr {
@@ -1181,7 +1190,8 @@ func TestEvaluator_isTargetIncludedOrExcludedInSegment(t *testing.T) {
1181
1190
for _ , tt := range tests {
1182
1191
t .Run (tt .name , func (t * testing.T ) {
1183
1192
e := Evaluator {
1184
- query : tt .fields .query ,
1193
+ query : tt .fields .query ,
1194
+ logger : logger .NewNoOpLogger (),
1185
1195
}
1186
1196
if got := e .isTargetIncludedOrExcludedInSegment (tt .args .segmentList , tt .args .target ); got != tt .want {
1187
1197
t .Errorf ("Evaluator.isTargetIncludedOrExcludedInSegment() = %v, want %v" , got , tt .want )
@@ -1263,7 +1273,8 @@ func TestEvaluator_checkPreRequisite(t *testing.T) {
1263
1273
for _ , tt := range tests {
1264
1274
t .Run (tt .name , func (t * testing.T ) {
1265
1275
e := Evaluator {
1266
- query : tt .fields .query ,
1276
+ query : tt .fields .query ,
1277
+ logger : logger .NewNoOpLogger (),
1267
1278
}
1268
1279
got , err := e .checkPreRequisite (tt .args .parent , tt .args .target )
1269
1280
if (err != nil ) != tt .wantErr {
@@ -1380,7 +1391,8 @@ func TestEvaluator_evaluate(t *testing.T) {
1380
1391
for _ , tt := range tests {
1381
1392
t .Run (tt .name , func (t * testing.T ) {
1382
1393
e := Evaluator {
1383
- query : tt .fields .query ,
1394
+ query : tt .fields .query ,
1395
+ logger : logger .NewNoOpLogger (),
1384
1396
}
1385
1397
got , err := e .evaluate (tt .args .identifier , tt .args .target , tt .args .kind )
1386
1398
if (err != nil ) != tt .wantErr {
@@ -1451,7 +1463,8 @@ func TestEvaluator_BoolVariation(t *testing.T) {
1451
1463
for _ , tt := range tests {
1452
1464
t .Run (tt .name , func (t * testing.T ) {
1453
1465
e := Evaluator {
1454
- query : tt .fields .query ,
1466
+ query : tt .fields .query ,
1467
+ logger : logger .NewNoOpLogger (),
1455
1468
}
1456
1469
if got := e .BoolVariation (tt .args .identifier , tt .args .target , tt .args .defaultValue ); got != tt .want {
1457
1470
t .Errorf ("Evaluator.BoolVariation() = %v, want %v" , got , tt .want )
@@ -1517,7 +1530,8 @@ func TestEvaluator_StringVariation(t *testing.T) {
1517
1530
for _ , tt := range tests {
1518
1531
t .Run (tt .name , func (t * testing.T ) {
1519
1532
e := Evaluator {
1520
- query : tt .fields .query ,
1533
+ query : tt .fields .query ,
1534
+ logger : logger .NewNoOpLogger (),
1521
1535
}
1522
1536
if got := e .StringVariation (tt .args .identifier , tt .args .target , tt .args .defaultValue ); got != tt .want {
1523
1537
t .Errorf ("Evaluator.StringVariation() = %v, want %v" , got , tt .want )
@@ -1595,7 +1609,8 @@ func TestEvaluator_IntVariation(t *testing.T) {
1595
1609
for _ , tt := range tests {
1596
1610
t .Run (tt .name , func (t * testing.T ) {
1597
1611
e := Evaluator {
1598
- query : tt .fields .query ,
1612
+ query : tt .fields .query ,
1613
+ logger : logger .NewNoOpLogger (),
1599
1614
}
1600
1615
if got := e .IntVariation (tt .args .identifier , tt .args .target , tt .args .defaultValue ); got != tt .want {
1601
1616
t .Errorf ("Evaluator.IntVariation() = %v, want %v" , got , tt .want )
@@ -1673,7 +1688,8 @@ func TestEvaluator_NumberVariation(t *testing.T) {
1673
1688
for _ , tt := range tests {
1674
1689
t .Run (tt .name , func (t * testing.T ) {
1675
1690
e := Evaluator {
1676
- query : tt .fields .query ,
1691
+ query : tt .fields .query ,
1692
+ logger : logger .NewNoOpLogger (),
1677
1693
}
1678
1694
if got := e .NumberVariation (tt .args .identifier , tt .args .target , tt .args .defaultValue ); got != tt .want {
1679
1695
t .Errorf ("Evaluator.NumberVariation() = %v, want %v" , got , tt .want )
@@ -1758,7 +1774,8 @@ func TestEvaluator_JSONVariation(t *testing.T) {
1758
1774
for _ , tt := range tests {
1759
1775
t .Run (tt .name , func (t * testing.T ) {
1760
1776
e := Evaluator {
1761
- query : tt .fields .query ,
1777
+ query : tt .fields .query ,
1778
+ logger : logger .NewNoOpLogger (),
1762
1779
}
1763
1780
if got := e .JSONVariation (tt .args .identifier , tt .args .target , tt .args .defaultValue ); ! reflect .DeepEqual (got , tt .want ) {
1764
1781
t .Errorf ("Evaluator.JSONVariation() = %v, want %v" , got , tt .want )
0 commit comments