Skip to content

Commit dae2d0c

Browse files
author
Dave Johnston
authored
[FFM-3441]: Unable to evaluate JSON multivariate (#82)
This change ensures we handle JSON types when evaluating with pre-reqs. Multivariate flags can contain JSON. This was missed from the current switch block.
1 parent 25509a7 commit dae2d0c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

evaluation/feature.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,10 @@ func (fc FeatureConfig) EvaluateWithPreReqFlags(target *Target, prereqFlags map[
242242
reflect.Uint32, reflect.Uint64, reflect.Uint8:
243243
fallthrough
244244
case reflect.Float64, reflect.Float32:
245+
fallthrough
246+
case reflect.Map:
245247
variation, err = getVariationWithPrereqs(fc, target, prereqFlags)
246-
case reflect.Map, reflect.Array, reflect.Chan, reflect.Complex128, reflect.Complex64, reflect.Func, reflect.Interface,
248+
case reflect.Array, reflect.Chan, reflect.Complex128, reflect.Complex64, reflect.Func, reflect.Interface,
247249
reflect.Invalid, reflect.Ptr, reflect.Slice, reflect.Struct, reflect.Uintptr, reflect.UnsafePointer:
248250
err = fmt.Errorf("unexpected type: %s for flag %s", fc.GetKind().String(), fc.Feature)
249251
}

0 commit comments

Comments
 (0)