Add prototype "set quick save here" feature #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely needs a UX pass and also some polishing generally
(e.g. we don't seem to set the BGM when modifying quick save data?)fixed!Also probably want to refactor out the code that saves the script preview to be shared between the dialog and this.Done! But wanted to push this up to show off something cool. :)Eventually, this should hook in with the script validator to determine if you're loading in at a safe spot.
Right now it lives in a context menu but I'd imagine we'd want to put it in the toolbar and such eventually as well.
As noted above, part of this work involved determining how BGM info was stored in quick save data and adding that to our model. We now account for it in both save editing and here.
https://bsky.app/profile/jonkode.su/post/3lkr3me4h6k24
Closes #533.
Update: While implementing Advanced Mode™️, I found that our implementation of flags was...well, wrong. The internal values are all correct but the display values don't match what's used in scripts. I made some adjustments and got it working.
Also, advanced mode now exists. Set flags, change friendship values, previous objective arrangements, etc., all from the comfort of the script command context menu. These values then persist as you set new quick saves.