Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state: deregister service with sunken token #12560

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blaggacao
Copy link

fixes: #12145

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@blaggacao
Copy link
Author

Works.

image

@Amier3
Copy link
Contributor

Amier3 commented Mar 22, 2022

Hey @blaggacao

Thanks for making this PR. Could you sign the CLA agreement so we could review it?

@Amier3
Copy link
Contributor

Amier3 commented Jun 7, 2022

Hey @blaggacao

Just a reminder that we'll need the CLA signed before reviewing this. Thank you!

@blaggacao blaggacao marked this pull request as ready for review July 28, 2022 18:17
@ncode
Copy link
Contributor

ncode commented Aug 26, 2022

This feature would be great to have. I'm currently experiencing this issue with short lived tokens and the de-registration and re-registration flow.

@mgomersbach
Copy link

This feature would be great to have. I'm currently experiencing this issue with short lived tokens and the de-registration and re-registration flow.

Same here, the vercel checks seem to fail, but don't have access to see why.

@blaggacao
Copy link
Author

blaggacao commented Aug 26, 2022

We use Nix to patch our way to happiness, so I'm not immediately incentiviced to push this.

The HC team should feel free to take over.

@blake
Copy link
Contributor

blake commented Aug 30, 2022

I approved the Vercel builds and they've both passed.

I'll find someone on the HC team to review the proposed changes.

@rehand
Copy link

rehand commented Mar 12, 2024

Hello,
I'm experiencing the same issue and I tried the PR and it works. It would be great if it can be reviewed soon.

@markan markan removed their assignment Mar 13, 2024
@rehand
Copy link

rehand commented Apr 8, 2024

@blake could you try to find someone to review the proposed changes?

Copy link

github-actions bot commented Jul 8, 2024

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Jul 8, 2024
@rehand
Copy link

rehand commented Jul 8, 2024

The issue is still present and the PR solves it.

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Jul 9, 2024
Copy link

github-actions bot commented Sep 7, 2024

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Sep 7, 2024
@rehand
Copy link

rehand commented Sep 12, 2024

The issue is still present and the PR solves it.

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Sep 13, 2024
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Nov 12, 2024
@rehand
Copy link

rehand commented Nov 12, 2024

The issue is still present and the PR solves it.

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Nov 13, 2024
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Jan 12, 2025
@rehand
Copy link

rehand commented Jan 13, 2025

The issue is still present and the PR solves it.

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

healthcheck token impersonation issue ("sunken tokens")
9 participants