-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state: deregister service with sunken token #12560
base: main
Are you sure you want to change the base?
Conversation
Hey @blaggacao Thanks for making this PR. Could you sign the CLA agreement so we could review it? |
Hey @blaggacao Just a reminder that we'll need the CLA signed before reviewing this. Thank you! |
This feature would be great to have. I'm currently experiencing this issue with short lived tokens and the de-registration and re-registration flow. |
Same here, the vercel checks seem to fail, but don't have access to see why. |
We use Nix to patch our way to happiness, so I'm not immediately incentiviced to push this. The HC team should feel free to take over. |
I approved the Vercel builds and they've both passed. I'll find someone on the HC team to review the proposed changes. |
Hello, |
@blake could you try to find someone to review the proposed changes? |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
The issue is still present and the PR solves it. |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
The issue is still present and the PR solves it. |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
The issue is still present and the PR solves it. |
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
The issue is still present and the PR solves it. |
fixes: #12145