New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API Group under backendRefs #21961

Merged

markcampv merged 2 commits into main from docs/change-backendRefs-api-group

Nov 22, 2024

Contributor

markcampv commented Nov 20, 2024 •

edited

Loading

Description

Currently backendRefs refers to api-gateway.consul.hashicorp.com as the API Group that should be used when kind is set to Mesh Service. Based on the mesh service template, it should just be consul.hashicorp.com.

Testing & Reproduction steps

Links

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern


          Update routes.mdx

a1c140d

Currently backendRefs refers to api-gateway.consul.hashicorp.com as the API Group that should be used when kind is set to Mesh Service. Based on mesh service template, it should just be consul.hashicorp.com.

markcampv requested a review from a team as a code owner

November 20, 2024 22:52

github-actions bot added the type/docs label

vercel bot deployed to Preview – consul

November 20, 2024 22:58

View deployment


          Update backendRefs in route to peered doc

77c78f3

vercel bot deployed to Preview – consul

November 21, 2024 19:53

View deployment

boruszak added pr/no-changelog backport/1.20 labels

boruszak approved these changes

View reviewed changes

Contributor

boruszak left a comment

LGTM

markcampv merged commit bbb2e79 into main

80 of 82 checks passed

markcampv deleted the docs/change-backendRefs-api-group branch

November 22, 2024 00:51

hc-github-team-consul-core mentioned this pull request

Backport of Update API Group under backendRefs into release/1.20.x #21965

Merged

4 tasks

Collaborator

hc-github-team-consul-core commented Nov 22, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

17 similar comments

Collaborator

hc-github-team-consul-core commented Nov 23, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 24, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 25, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 26, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 27, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 28, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 29, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Nov 30, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 1, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 2, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 3, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 4, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 5, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 6, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 7, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 8, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 9, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 10, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

16 similar comments

Collaborator

hc-github-team-consul-core commented Dec 11, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 12, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 13, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 14, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 15, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 16, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 17, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 18, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 19, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 20, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 21, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 22, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 23, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 23, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 23, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Dec 23, 2024

📣 Hi @markcampv! a backport is missing for this PR [21961] for versions [1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.20 pr/no-changelog type/docs