ResolveLinkToExternal: fix how the dependency is checked #3424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
we need to test this in cloud-ui, the last time I tried this approach it failed but since that time there were some upgrades upstream on embroider side so this might have been fixed, so it would make sense to bump embroider/macros |
aklkv
reviewed
Dec 5, 2025
| // @ts-expect-error: we list this as optional peer dependency | ||
| if (macroCondition(dependencySatisfies('ember-engines', '*'))) { | ||
| // Use importSync for compile-time conditional import | ||
| const module = importSync( |
Collaborator
There was a problem hiding this comment.
Suggested change
| const module = importSync( | |
| const { default: module } = importSync( |
aklkv
reviewed
Dec 5, 2025
| return mod.default as typeof LinkTo; | ||
| } catch { | ||
| ) as { default: typeof LinkTo }; | ||
| return module.default; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return module.default; | |
| return module; |
shleewhite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is another fix from the flaky test investigation.
It changes the way the util checks that ember-engines is a dependency.
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.