func: add default historical apm getter to avoid panics

Juanadelacuesta · Juanadelacuesta · commit 158d587a8b60 · 2025-08-15T15:49:15.000+02:00
diff --git a/policy/handler_oss.go b/policy/handler_oss.go
@@ -14,6 +14,8 @@ import (
 
 type HistoricalAPMGetter interface{}
 
+type noopHistoricalAPMGetter struct{}
+
 type noopVerticalCheckRunner struct {
 	policy *sdk.ScalingPolicy
 }
diff --git a/policy/manager.go b/policy/manager.go
@@ -68,8 +68,6 @@ type Manager struct {
 	historicalAPMGetter HistoricalAPMGetter
 }
 
-type noopHistoricalAPMGetter struct{}
-
 // NewManager returns a new Manager.
 func NewManager(log hclog.Logger, ps map[SourceName]Source, pm *manager.PluginManager, mInt time.Duration, l *Limiter) *Manager {
 

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ import (`
`14`	`14`
`15`	`15`	`type HistoricalAPMGetter interface{}`
`16`	`16`
	`17`	`+type noopHistoricalAPMGetter struct{}`
	`18`	`+`
`17`	`19`	`type noopVerticalCheckRunner struct {`
`18`	`20`	`policy *sdk.ScalingPolicy`
`19`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,6 @@ type Manager struct {`
`68`	`68`	`historicalAPMGetter HistoricalAPMGetter`
`69`	`69`	`}`
`70`	`70`
`71`		`-type noopHistoricalAPMGetter struct{}`
`72`		`-`
`73`	`71`	`// NewManager returns a new Manager.`
`74`	`72`	`func NewManager(log hclog.Logger, ps map[SourceName]Source, pm manager.PluginManager, mInt time.Duration, l Limiter) *Manager {`
`75`	`73`