Add a note about defaults

jefferai · jefferai · commit fffbc4eca579 · 2020-04-16T15:10:20.000-04:00
diff --git a/path_config.go b/path_config.go
@@ -239,6 +239,9 @@ func (b *jwtAuthBackend) pathConfigWrite(ctx context.Context, req *logical.Reque
 		return nil, errors.New("unknown condition")
 	}
 
+	// NOTE: the OIDC lib states that if nothing is passed into its config, it
+	// defaults to "RS256". So in the case of a zero value here it won't
+	// default to e.g. "none".
 	for _, a := range config.JWTSupportedAlgs {
 		switch a {
 		case oidc.RS256, oidc.RS384, oidc.RS512, oidc.ES256, oidc.ES384, oidc.ES512, oidc.PS256, oidc.PS384, oidc.PS512:

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,9 @@ func (b jwtAuthBackend) pathConfigWrite(ctx context.Context, req logical.Reque`
`239`	`239`	`return nil, errors.New("unknown condition")`
`240`	`240`	`}`
`241`	`241`
	`242`	`+ // NOTE: the OIDC lib states that if nothing is passed into its config, it`
	`243`	`+ // defaults to "RS256". So in the case of a zero value here it won't`
	`244`	`+ // default to e.g. "none".`
`242`	`245`	`for _, a := range config.JWTSupportedAlgs {`
`243`	`246`	`switch a {`
`244`	`247`	`case oidc.RS256, oidc.RS384, oidc.RS512, oidc.ES256, oidc.ES384, oidc.ES512, oidc.PS256, oidc.PS384, oidc.PS512:`