-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning-less and unnecessary orphans. #41
Comments
@bitemyapp thanks for reporting this. I ran into this last night when I was baffled by the fact that the Haddock included the Show instance for I think that in general, Show instances should only be used for debug messaging, and as you provide plenty of functions for doing proper rendering of UTCTime functions to strings, it would be very helpful if these instances were not orphaned; I really prefer if runtime behavior does change depending upon which modules are imported into a scope. |
I'll look into this… |
This is how it is done in the time package. I'd also think it should go with the UTCTime instance, though there might be some arcane code depending on this behaviour (I guess the think shouldn't link anyway if some competing |
I ran into the same issue with ToJSON/FromJSON. The orphan instances are in Data.Thyme.Format.Aeson, and importing Data.Thyme (UTCTime) doesn't bring them into scope. It was pretty confusing. |
Show instance for
UTCTime
doesn't appear unless you import Data.Thyme.Format / Data.Thyme.LocalTime.The text was updated successfully, but these errors were encountered: