Haskell CI: turn of -Werror=unused-packages; hopeless for github-samples

Author: andreasabel

.github/workflows/haskell-ci.yml

@@ -246,10 +246,6 @@ jobs:
           echo "    ghc-options: -Werror=missing-methods -Werror=missing-fields" >> cabal.project
           if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "package github-samples" >> cabal.project ; fi
           if [ $((HCNUMVER >= 80400)) -ne 0 ] ; then echo "    ghc-options: -Werror=missing-methods -Werror=missing-fields" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "package github" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "    ghc-options: -Werror=unused-packages" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "package github-samples" >> cabal.project ; fi
-          if [ $((HCNUMVER >= 90400)) -ne 0 ] ; then echo "    ghc-options: -Werror=unused-packages" >> cabal.project ; fi
           if [ $((HCNUMVER >= 90000)) -ne 0 ] ; then echo "package github" >> cabal.project ; fi
           if [ $((HCNUMVER >= 90000)) -ne 0 ] ; then echo "    ghc-options: -Werror=incomplete-patterns -Werror=incomplete-uni-patterns" >> cabal.project ; fi
           if [ $((HCNUMVER >= 90000)) -ne 0 ] ; then echo "package github-samples" >> cabal.project ; fi

cabal.haskell-ci

@@ -3,6 +3,11 @@ haddock: >=8.6
   -- See PR #355: haddocks for GADT constructor arguments only supported from GHC 8.6
 jobs-selection: any
 
+-- Package github-samples uses "include" for dependencies,
+-- so they are a superset.
+-- Dissecting this is a waste of time, so I turn -Werror=unused-packages off
+error-unused-packages: False
+
 -- Some dependencies do not allow mtl-2.3 yet, so this doesn't pass yet:
 -- constraint-set mtl-2.3
 --   ghc: >= 8.6

samples/github-samples.cabal

@@ -29,7 +29,6 @@ library
   build-depends:
     , base                   >=4.11 && <5
         -- require base-4.11 because then (<>) is in Prelude
-    , base-compat-batteries
     , github
     , text