-
Notifications
You must be signed in to change notification settings - Fork 113
Description
Right now parsing is our slowest task, and yet parsing occurs during evaluation all the time due to import
expressions. It would be nice if we could assign a pool of N workers (using the async-pool
library), and perform these slow evaluations concurrently since none of them can have interfering side-effects. This should speed up the evaluation of nixpkgs
considerably if there are many capabilities available.
To do this will need a few steps:
-
Make
Thunk.hs
thread-safe by introducing a variable that causes other threads to wait for pending evaluations to complete. Right now there is a boolean flag in anIORef
; it might be sufficient to just turn this into a trinary flag in aTVar
. -
Create
MonadConcurrent
to abstract when concurrent evaluation is possible. It wouldn't be for the symbolic evaluator, for example, but would for an evaluator that runs in IO, such asLazy
. -
Replace the calls to
traverse
that happen inExec.hs
forNList
andNSet
to instead use a newconcurrentTraverse
method defined inMonadConcurrent
, which for IO would be implemented by callingControl.Concurrent.Async.Pool.mapTasks <group>
and for pure evaluation would just calltraverse
as before.
Pinging @ryantrinkle, who requested this feature.