Improve s-b-i frontend command and add tests

Also, rename new-show-build-info to show-build-info in ShowBuildInfo

Author: fendor

Cabal/Distribution/Simple/ShowBuildInfo.hs

@@ -2,7 +2,7 @@
 -- This module defines a simple JSON-based format for exporting basic
 -- information about a Cabal package and the compiler configuration Cabal
 -- would use to build it. This can be produced with the
--- @cabal new-show-build-info@ command.
+-- @cabal show-build-info@ command.
 --
 --
 -- This format is intended for consumption by external tooling and should

cabal-install/Distribution/Client/CmdBuild.hs

@@ -8,7 +8,8 @@ module Distribution.Client.CmdBuild (
     -- * Internals exposed for testing
     TargetProblem(..),
     selectPackageTargets,
-    selectComponentTarget
+    selectComponentTarget,
+    reportTargetProblems
   ) where
 
 import Prelude ()

cabal-install/Distribution/Client/CmdShowBuildInfo.hs

@@ -53,10 +53,7 @@ module Distribution.Client.Setup
     , doctestCommand
     , copyCommand
     , registerCommand
-
-    --ghc-mod support commands
-    , showBuildInfoCommand
-    , writeAutogenFilesCommand, WriteAutogenFilesFlags(..)
+    --, showBuildInfoCommand
     , parsePackageArgs
     , liftOptions
     , yesNoOpt
@@ -103,7 +100,6 @@ import Distribution.Simple.Setup
          , SDistFlags(..), HaddockFlags(..)
          , CleanFlags(..), DoctestFlags(..)
          , CopyFlags(..), RegisterFlags(..)
-         , WriteAutogenFilesFlags(..)
          , readPackageDbList, showPackageDbList
          , Flag(..), toFlag, flagToMaybe, flagToList, maybeToFlag
          , BooleanFlag(..), optionVerbosity
@@ -197,7 +193,6 @@ globalCommand commands = CommandUI {
           , "haddock"
           , "hscolour"
           , "show-build-info"
-          , "write-autogen-files"
           , "exec"
           , "new-build"
           , "new-configure"
@@ -285,7 +280,6 @@ globalCommand commands = CommandUI {
         , addCmd "report"
         , par
         , addCmd "show-build-info"
-        , addCmd "write-autogen-files"
         , addCmd "freeze"
         , addCmd "gen-bounds"
         , addCmd "outdated"
@@ -869,25 +863,6 @@ filterTestFlags flags cabalLibVersion
       Cabal.testWrapper = NoFlag
       }
 
--- ------------------------------------------------------------
--- * show-build-info command
--- ------------------------------------------------------------
-
-showBuildInfoCommand :: CommandUI (BuildFlags, BuildExFlags)
-showBuildInfoCommand = parent {
-    commandDefaultFlags = (commandDefaultFlags parent, mempty),
-    commandOptions      =
-      \showOrParseArgs -> liftOptions fst setFst
-                          (commandOptions parent showOrParseArgs)
-                          ++
-                          liftOptions snd setSnd (buildExOptions showOrParseArgs)
-  }
-  where
-    setFst a (_,b) = (a,b)
-    setSnd b (a,_) = (a,b)
-
-    parent = Cabal.showBuildInfoCommand defaultProgramDb
-
 -- ------------------------------------------------------------
 -- * Repl command
 -- ------------------------------------------------------------
@@ -2973,10 +2948,10 @@ relevantConfigValuesText vs =
 
 
 -- ------------------------------------------------------------
--- * Commands to support ghc-mod
+-- * Commands to support show-build-info
 -- ------------------------------------------------------------
 
-showBuildInfoCommand :: CommandUI (BuildFlags, BuildExFlags)
+showBuildInfoCommand :: CommandUI (Cabal.ShowBuildInfoFlags, BuildExFlags)
 showBuildInfoCommand = parent {
     commandDefaultFlags = (commandDefaultFlags parent, mempty),
     commandOptions      =
@@ -2990,6 +2965,3 @@ showBuildInfoCommand = parent {
     setSnd b (a,_) = (a,b)
 
     parent = Cabal.showBuildInfoCommand defaultProgramDb
-
-writeAutogenFilesCommand :: CommandUI WriteAutogenFilesFlags
-writeAutogenFilesCommand = Cabal.writeAutogenFilesCommand defaultProgramDb

cabal-install/Distribution/Client/CmdWriteAutogenFiles.hs

@@ -18,7 +18,7 @@
 -- runs it with the given arguments.
 
 module Distribution.Client.SetupWrapper (
-    getSetup, runSetup, runSetupCommand, setupWrapper,
+    getSetup, runSetup, runSetupCommand, setupWrapper, getSetupMethod,
     SetupScriptOptions(..),
     defaultSetupScriptOptions,
   ) where

cabal-install/Distribution/Client/Setup.hs

@@ -160,8 +160,6 @@ executable cabal
         Distribution.Client.CmdBench
         Distribution.Client.CmdBuild
         Distribution.Client.CmdClean
-        Distribution.Client.CmdShowBuildInfo
-        Distribution.Client.CmdWriteAutogenFiles
         Distribution.Client.CmdConfigure
         Distribution.Client.CmdUpdate
         Distribution.Client.CmdErrorMessages
@@ -174,6 +172,7 @@ executable cabal
         Distribution.Client.CmdRepl
         Distribution.Client.CmdRun
         Distribution.Client.CmdRun.ClientRunFlags
+        Distribution.Client.CmdShowBuildInfo
         Distribution.Client.CmdTest
         Distribution.Client.CmdLegacy
         Distribution.Client.CmdSdist

cabal-install/Distribution/Client/SetupWrapper.hs

@@ -111,6 +111,7 @@
         Distribution.Client.CmdRepl
         Distribution.Client.CmdRun
         Distribution.Client.CmdRun.ClientRunFlags
+        Distribution.Client.CmdShowBuildInfo
         Distribution.Client.CmdTest
         Distribution.Client.CmdLegacy
         Distribution.Client.CmdSdist