Skip to content

[meta] GH: default token permissions? #10332

Open
@geekosaur

Description

@geekosaur

(from https://github.com/haskell/cabal/pull/10331/files#r1748758142 ff.)

I should note that, if the default token does in fact have permissions to make releases, what other permissions does it have that might be problematic with respect to random composite actions? Does someone need to audit the actions we use regularly to make sure they're safe? The actual (as opposed to documented) permissions structure seems to lean a bit too far toward convenience over security.

(Background: GitHub Actions documentation claims that "actions" (formally "composite actions" per GHA docs) don't have access to the workflow's token, but it appears that in fact they do. (In fact, I just read through it again, and it's talking about secrets, which are a different feature that we don't use and don't include the workflow's tokens. Which leaves open the question of token security.) The default token also apparently has sufficient permissions to make releases, again contrary to documentation including the documentation for the auto-release action we are using, which asserts that we need to grant the workflow token permissions: write. From a security standpoint, this is worrisome.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions