Skip to content

CI doesn't ensure cabal install cabal-install from previous major series works #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ezyang opened this issue Jul 13, 2016 · 5 comments
Closed

Comments

@ezyang
Copy link
Contributor

ezyang commented Jul 13, 2016

Self-explanatory. Probably should just make a separate job in the matrix for testing this case.

@phadej
Copy link
Collaborator

phadej commented Jul 13, 2016

Do you have an example? AFAICS cabal check should say aloud if cabal-version is too low, also we have setup-deps...

@23Skidoo
Copy link
Member

To clarify: this means cabal-install-1.24 install cabal-install-1.26, not cabal-install-1.26 install cabal-install-1.24.

@23Skidoo
Copy link
Member

In general, we need a more systematic pre-release testing procedure.

@ezyang
Copy link
Contributor Author

ezyang commented Jul 13, 2016

The way the Travis script works is by first bootstrapping cabal-install using bootstrap.sh, and then using the resulting cabal for the rest of the operations. So this won't check if cabal-install-1.24 install cabal-install-1.26 works, as @23Skidoo says. I noticed this when I was working on the internal libraries PR, because for cabal-install to use internal libraries requires a sufficiently new version of Cabal, but the CI wasn't failing.

@jneira
Copy link
Member

jneira commented Mar 11, 2022

Now github workflows does:

So the issue request was being done since time ago and we check cabal-head too (As travis did when this issue was opened)

@jneira jneira closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants