Skip to content

Sporadic failures in PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robx opened this issue Apr 4, 2022 · 2 comments
Closed

Sporadic failures in PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs #8080

robx opened this issue Apr 4, 2022 · 2 comments
Assignees
@robx
Labels
type: bug type: testing Issues about project test suites

Comments

@robx
Copy link
Collaborator

robx commented Apr 4, 2022 •
edited
Loading

Describe the bug

I see two recent master CI failures with PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs:

That test was added in #7921.

+ /Users/runner/work/cabal/cabal/dist-newstyle-validate-ghc-9.0.2/build/x86_64-osx/ghc-9.0.2/cabal-install-3.7.0.0/x/cabal/build/cabal/cabal v2-run exe
Up to date
terminated

stderr:
*** Exception:  expected: exiting
CallStack (from HasCallStack):
  assertOutputContains, called at PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs:34:3 in main:Main

*** unexpected failure for PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs
@robx robx self-assigned this Apr 4, 2022
robx added a commit to robx/cabal that referenced this issue Apr 4, 2022
@robx
Fix race condition in PackageTests/NewBuild/CmdRun/Terminate
2521ee9 
The "up and running" file was written before the signal handler
was installed, so it was possible for the test to kill the
subprocess before, leading to a missed "exiting" line in the
output.

I hope this fixes the sporadic failures we're seeing (haskell#8080).
@robx robx mentioned this issue Apr 4, 2022
Merged
3 tasks
@jneira jneira added type: bug type: testing Issues about project test suites labels Apr 4, 2022
@robx
Copy link
Collaborator Author

robx commented Apr 5, 2022

We've merged a likely fix with #8081, let's keep this open for a bit to see whether the test still fails, and if it looks fine this can be closed.

@robx
Copy link
Collaborator Author

robx commented Apr 26, 2022

I've checked the last couple CI runs, looks like this isn't failing anymore (though a bit hard to tell for sure with other failures). Closing, but do feel free to reopen if it starts failing again!

@robx robx closed this as completed Apr 26, 2022
@andreasabel andreasabel mentioned this issue Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robx robx

Labels
type: bug type: testing Issues about project test suites
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jneira @robx