Merge pull request #555 from Lezune/users/Lezune/Foundations-AudioTranscriptions-Update

glhays · web-flow · commit 625e735a41a9 · 2024-06-12T13:33:57.000-07:00
CODE RUB: Foundations AudioTranscriptions Exceptions Update v2.10.1
diff --git a/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AudioTranscriptions/AudioTranscriptionServiceTests.Validations.Send.cs b/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AudioTranscriptions/AudioTranscriptionServiceTests.Validations.Send.cs
@@ -20,7 +20,8 @@ private async Task ShouldThrowValidationExceptionOnSendIfAudioTranscriptionIsNul
             // given
             AudioTranscription audioTranscription = null;
 
-            var nullAudioTranscriptionException = new NullAudioTranscriptionException();
+            var nullAudioTranscriptionException = new NullAudioTranscriptionException(
+                message: "Audio transcription is null.");
 
             var exceptedAudioTranscriptionValidationException =
                 new AudioTranscriptionValidationException(
@@ -56,7 +57,9 @@ private async Task ShouldThrowValidationExceptionOnSendIfAudioTranscriptionReque
                 Request = null
             };
 
-            var invalidAudioTranscriptionException = new InvalidAudioTranscriptionException();
+            var invalidAudioTranscriptionException =
+                new InvalidAudioTranscriptionException(
+                    message: "Audio transcription is invalid.");
 
             invalidAudioTranscriptionException.AddData(
                 key: nameof(AudioTranscription.Request),
@@ -103,7 +106,9 @@ private async Task ShouldThrowValidationExceptionOnSendIfAudioTranscriptionReque
                 }
             };
 
-            var invalidAudioTranscriptionException = new InvalidAudioTranscriptionException();
+            var invalidAudioTranscriptionException =
+                new InvalidAudioTranscriptionException(
+                message: "Audio transcription is invalid."); 
 
             invalidAudioTranscriptionException.AddData(
                 key: nameof(AudioTranscriptionRequest.FileName),
diff --git a/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AudioTranscriptions/AudioTranscriptionServiceTests.cs b/Standard.AI.OpenAI.Tests.Unit/Services/Foundations/AudioTranscriptions/AudioTranscriptionServiceTests.cs
@@ -10,6 +10,7 @@
 using RESTFulSense.Exceptions;
 using Standard.AI.OpenAI.Brokers.OpenAIs;
 using Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions;
+using Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exceptions;
 using Standard.AI.OpenAI.Models.Services.Foundations.ExternalAudioTranscriptions;
 using Standard.AI.OpenAI.Services.Foundations.AudioTranscriptions;
 using Tynamix.ObjectFiller;
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionDependencyException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionDependencyException.cs
@@ -9,12 +9,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class AudioTranscriptionDependencyException : Xeption
     {
-        public AudioTranscriptionDependencyException(Xeption innerException)
-            : base(
-                message: "Audio transcription dependency error occurred, contact support.",
-                    innerException: innerException)
-        { }
-
         public AudioTranscriptionDependencyException(string message, Xeption innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionDependencyValidationException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionDependencyValidationException.cs
@@ -9,12 +9,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class AudioTranscriptionDependencyValidationException : Xeption
     {
-        public AudioTranscriptionDependencyValidationException(Xeption innerException)
-            : base(
-                message: "Chat completion dependency validation error occurred, fix errors and try again.",
-                    innerException: innerException)
-        { }
-
         public AudioTranscriptionDependencyValidationException(string message, Xeption innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionServiceException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionServiceException.cs
@@ -10,12 +10,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class AudioTranscriptionServiceException : Xeption
     {
-        public AudioTranscriptionServiceException(Exception innerException)
-            : base(
-                message: "Audio transcription service error occurred, contact support.",
-                    innerException: innerException)
-        { }
-
         public AudioTranscriptionServiceException(string message, Exception innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionValidationException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/AudioTranscriptionValidationException.cs
@@ -9,12 +9,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class AudioTranscriptionValidationException : Xeption
     {
-        public AudioTranscriptionValidationException(Xeption innerException)
-            : base(
-                message: "Audio transcription validation error occurred, fix errors and try again.",
-                    innerException: innerException)
-        { }
-
         public AudioTranscriptionValidationException(string message, Xeption innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/ExcessiveCallAudioTranscriptionException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/ExcessiveCallAudioTranscriptionException.cs
@@ -10,12 +10,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class ExcessiveCallAudioTranscriptionException : Xeption
     {
-        public ExcessiveCallAudioTranscriptionException(Exception innerException)
-            : base(
-                message: "Excessive call error occurred, limit your calls.",
-                    innerException: innerException)
-        { }
-
         public ExcessiveCallAudioTranscriptionException(string message, Exception innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/FailedAudioTranscriptionServiceException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/FailedAudioTranscriptionServiceException.cs
@@ -10,12 +10,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class FailedAudioTranscriptionServiceException : Xeption
     {
-        public FailedAudioTranscriptionServiceException(Exception innerException)
-            : base(
-                message: "Failed Audio Transcription Service Exception occurred, please contact support for assistance.",
-                    innerException: innerException)
-        { }
-
         public FailedAudioTranscriptionServiceException(string message, Exception innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/InvalidAudioTranscriptionException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/InvalidAudioTranscriptionException.cs
@@ -10,15 +10,8 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class InvalidAudioTranscriptionException : Xeption
     {
-        public InvalidAudioTranscriptionException()
-            : base(
-                message: "Audio transcription is invalid.")
-        { }
-
-        public InvalidAudioTranscriptionException(Exception innerException)
-            : base(
-                message: "Audio transcription is invalid.",
-                    innerException: innerException)
+        public InvalidAudioTranscriptionException(string message)
+            : base(message)
         { }
 
         public InvalidAudioTranscriptionException(string message, Exception innerException)
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/InvalidConfigurationAudioTranscriptionException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/InvalidConfigurationAudioTranscriptionException.cs
@@ -10,12 +10,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class InvalidConfigurationAudioTranscriptionException : Xeption
     {
-        public InvalidConfigurationAudioTranscriptionException(Exception innerException)
-            : base(
-                message: "Invalid audio transcription configuration error occurred, contact support.",
-                    innerException: innerException)
-        { }
-
         public InvalidConfigurationAudioTranscriptionException(string message, Exception innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/NullAudioTranscriptionException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/NullAudioTranscriptionException.cs
@@ -9,9 +9,8 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class NullAudioTranscriptionException : Xeption
     {
-        public NullAudioTranscriptionException()
-            : base(
-                message: "Audio transcription is null.")
+        public NullAudioTranscriptionException(string message)
+            : base(message)
         { }
 
         public NullAudioTranscriptionException(string message, Xeption innerException)
diff --git a/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/UnauthorizedAudioTranscriptionException.cs b/Standard.AI.OpenAI/Models/Services/Foundations/AudioTranscriptions/Exceptions/UnauthorizedAudioTranscriptionException.cs
@@ -10,12 +10,6 @@ namespace Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exc
 #pragma warning disable RCS1194 // Implement exception constructors.
     public class UnauthorizedAudioTranscriptionException : Xeption
     {
-        public UnauthorizedAudioTranscriptionException(Exception innerException)
-            : base(
-                message: "Unauthorized audio transcription request, fix errors and try again.",
-                    innerException: innerException)
-        { }
-
         public UnauthorizedAudioTranscriptionException(string message, Exception innerException)
             : base(message, innerException)
         { }
diff --git a/Standard.AI.OpenAI/Services/Foundations/AudioTranscriptions/AudioTranscriptionService.Exceptions.cs b/Standard.AI.OpenAI/Services/Foundations/AudioTranscriptions/AudioTranscriptionService.Exceptions.cs
@@ -7,6 +7,7 @@
 using RESTFulSense.Exceptions;
 using Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions;
 using Standard.AI.OpenAI.Models.Services.Foundations.AudioTranscriptions.Exceptions;
+using Xeptions;
 
 namespace Standard.AI.OpenAI.Services.Foundations.AudioTranscriptions
 {
@@ -23,54 +24,111 @@ private static async ValueTask<AudioTranscription> TryCatch(
             }
             catch (NullAudioTranscriptionException nullAudioTranscriptionException)
             {
-                throw new AudioTranscriptionValidationException(nullAudioTranscriptionException);
+                throw CreateAudioTranscriptionValidationException(
+                    nullAudioTranscriptionException);
             }
             catch (InvalidAudioTranscriptionException invalidAudioTranscriptionException)
             {
-                throw new AudioTranscriptionValidationException(invalidAudioTranscriptionException);
+                throw CreateAudioTranscriptionValidationException(
+                    invalidAudioTranscriptionException);
             }
             catch (HttpResponseUrlNotFoundException httpResponseUrlNotFoundException)
             {
                 var invalidConfigurationAudioTranscriptionException =
-                    new InvalidConfigurationAudioTranscriptionException(httpResponseUrlNotFoundException);
+                    new InvalidConfigurationAudioTranscriptionException(
+                        message: "Invalid audio transcription configuration error occurred, contact support.",
+                        httpResponseUrlNotFoundException);
 
-                throw new AudioTranscriptionDependencyException(invalidConfigurationAudioTranscriptionException);
+                throw CreateAudioTranscriptionDependencyException(
+                    invalidConfigurationAudioTranscriptionException);
             }
             catch (HttpResponseUnauthorizedException httpResponseUnauthorizedException)
             {
                 var unauthorizedAudioTranscriptionException =
-                    new UnauthorizedAudioTranscriptionException(httpResponseUnauthorizedException);
+                    new UnauthorizedAudioTranscriptionException(
+                        message: "Unauthorized audio transcription request, fix errors and try again.", 
+                        httpResponseUnauthorizedException);
 
-                throw new AudioTranscriptionDependencyException(unauthorizedAudioTranscriptionException);
+                throw CreateAudioTranscriptionDependencyException(
+                    unauthorizedAudioTranscriptionException);
             }
             catch (HttpResponseForbiddenException httpResponseForbiddenException)
             {
                 var unauthorizedAudioTranscriptionException =
-                    new UnauthorizedAudioTranscriptionException(httpResponseForbiddenException);
+                    new UnauthorizedAudioTranscriptionException(
+                        message: "Unauthorized audio transcription request, fix errors and try again.", 
+                        httpResponseForbiddenException);
 
-                throw new AudioTranscriptionDependencyException(unauthorizedAudioTranscriptionException);
+                throw CreateAudioTranscriptionDependencyException(
+                    unauthorizedAudioTranscriptionException);
             }
             catch (HttpResponseBadRequestException httpResponseBadRequestException)
             {
                 var invalidAudioTranscriptionException =
-                    new InvalidAudioTranscriptionException(httpResponseBadRequestException);
+                    new InvalidAudioTranscriptionException(
+                        message: "Audio transcription is invalid.",
+                        httpResponseBadRequestException);
 
-                throw new AudioTranscriptionDependencyValidationException(invalidAudioTranscriptionException);
+                throw CreateAudioTranscriptionDependencyValidationException(
+                    invalidAudioTranscriptionException);
             }
             catch (HttpResponseTooManyRequestsException httpResponseTooManyRequestsException)
             {
                 var excessiveCallAudioTranscriptionException =
-                    new ExcessiveCallAudioTranscriptionException(httpResponseTooManyRequestsException);
+                    new ExcessiveCallAudioTranscriptionException(
+                        message: "Excessive call error occurred, limit your calls.",
+                        httpResponseTooManyRequestsException);
 
-                throw new AudioTranscriptionDependencyValidationException(excessiveCallAudioTranscriptionException);
+                throw CreateAudioTranscriptionDependencyValidationException(
+                    excessiveCallAudioTranscriptionException);
             }
             catch (Exception exception)
             {
                 var failedAudioTranscriptionServiceException =
-                    new FailedAudioTranscriptionServiceException(exception);
+                    new FailedAudioTranscriptionServiceException(
+                        message: "Failed Audio Transcription Service Exception occurred," +
+                        " please contact support for assistance.", 
+                        exception);
 
-                throw new AudioTranscriptionServiceException(failedAudioTranscriptionServiceException);
+                throw CreateAudioTranscriptionServiceException(
+                    failedAudioTranscriptionServiceException);
             }
         }
+
+        private static AudioTranscriptionValidationException 
+            CreateAudioTranscriptionValidationException(Xeption innerException)
+        {
+
+            return new AudioTranscriptionValidationException(
+                message: "Audio transcription validation error occurred, fix errors and try again.",
+                innerException);
+        }
+
+        private static AudioTranscriptionDependencyException 
+            CreateAudioTranscriptionDependencyException(Xeption innerException)
+        {
+
+            return new AudioTranscriptionDependencyException(
+                message: "Audio transcription dependency error occurred, contact support.",
+                innerException);
+        }
+
+        private static AudioTranscriptionDependencyValidationException 
+            CreateAudioTranscriptionDependencyValidationException(Xeption innerException)
+        {
+
+            return new AudioTranscriptionDependencyValidationException(
+                message: "Chat completion dependency validation error occurred, fix errors and try again.",
+                innerException);
+        }
+
+        private static AudioTranscriptionServiceException 
+            CreateAudioTranscriptionServiceException(Xeption innerException)
+        {
+
+            return new AudioTranscriptionServiceException(
+                message: "Audio transcription service error occurred, contact support.",
+                innerException);
+        }
     }
 }
diff --git a/Standard.AI.OpenAI/Services/Foundations/AudioTranscriptions/AudioTranscriptionService.Validations.cs b/Standard.AI.OpenAI/Services/Foundations/AudioTranscriptions/AudioTranscriptionService.Validations.cs
@@ -30,7 +30,8 @@ private static void ValidateAudioTranscriptionIsNotNull(AudioTranscription audio
         {
             if (audioTranscription is null)
             {
-                throw new NullAudioTranscriptionException();
+                throw new NullAudioTranscriptionException(
+                    message: "Audio transcription is null.");
             }
         }
 
@@ -48,7 +49,9 @@ private static void ValidateAudioTranscriptionIsNotNull(AudioTranscription audio
 
         private static void Validate(params (dynamic Rule, string Parameter)[] validations)
         {
-            InvalidAudioTranscriptionException invalidAudioTranscriptionException = new InvalidAudioTranscriptionException();
+            InvalidAudioTranscriptionException invalidAudioTranscriptionException = 
+                new InvalidAudioTranscriptionException(
+                    message: "Audio transcription is invalid.");
 
             foreach ((dynamic rule, string parameter) in validations)
             {
