Skip to content

Commit f53e2a0

Browse files
Update ndc-sdk version to v1.6.0 (#151)
<!-- The PR description should answer 2 (maybe 3) important questions: --> ### What <!-- What is this PR trying to accomplish (and why, if it's not obvious)? --> ### How <!-- How is it trying to accomplish it (what are the implementation steps)? --> --------- Co-authored-by: py <[email protected]> Co-authored-by: pranshi06 <[email protected]>
1 parent 3242aa9 commit f53e2a0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+720
-622
lines changed

Cargo.lock

Lines changed: 45 additions & 89 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ unused_async = "allow"
4848

4949
[workspace.dependencies]
5050
# ndc-models was using version 0.1.2 but we needed rustls fix
51-
ndc-models = { git = "https://github.com/hasura/ndc-spec.git", rev = "c59f824ff95e6a376c34f85816e80164bc1f3894" }
52-
ndc-sdk = { git = "https://github.com/hasura/ndc-sdk-rs.git", rev = "a273a01efccfc71ef3341cf5f357b2c9ae2d109f", default-features = false, features = ["rustls"]}
53-
# ndc-test was using version 0.1.2 but we needed rustls fix
54-
ndc-test = { git = "https://github.com/hasura/ndc-spec.git", rev = "c59f824ff95e6a376c34f85816e80164bc1f3894", default-features = false, features = ["rustls"] }
51+
52+
ndc-models = { git = "https://github.com/hasura/ndc-spec.git", tag = "v0.1.6" }
53+
ndc-sdk = { git = "https://github.com/hasura/ndc-sdk-rs.git", tag = "v0.4.0" }
54+
ndc-test = { git = "https://github.com/hasura/ndc-spec.git", tag = "v0.1.6" }
55+
56+
smol_str = "0.1"

crates/cli/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,5 @@ tokio = { version = "1.37.0", features = ["full"] }
2121
[dev-dependencies]
2222
tempfile = "3.10.1"
2323

24-
[build-dependencies]
25-
build-data = "0.2.1"
26-
2724
[package.metadata.cargo-machete]
2825
ignored = ["build_data"] # apparently cargo-machete doesn't find dependencies used by build scripts

crates/cli/tests/update_tests.rs

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,15 @@ async fn test_update_configuration() -> anyhow::Result<()> {
4646
let contents = fs::read_to_string(configuration_file_path).await?;
4747
common::assert_ends_with_newline(&contents);
4848
let output: RawConfiguration = serde_json::from_str(&contents)?;
49-
match output {
50-
configuration::RawConfiguration {
51-
mssql_connection_string,
52-
metadata,
53-
..
54-
} => {
55-
assert_eq!(mssql_connection_string, connection_uri);
56-
let some_table_metadata = metadata.tables.0.get("Artist");
57-
assert!(some_table_metadata.is_some());
58-
}
49+
let configuration::RawConfiguration {
50+
mssql_connection_string,
51+
metadata,
52+
..
53+
} = output;
54+
{
55+
assert_eq!(mssql_connection_string, connection_uri);
56+
let some_table_metadata = metadata.tables.0.get("Artist");
57+
assert!(some_table_metadata.is_some());
5958
}
6059

6160
Ok(())

crates/configuration/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ edition.workspace = true
77
workspace = true
88

99
[dependencies]
10+
ndc-models = { workspace = true }
1011
query-engine-metadata = { path = "../query-engine/metadata" }
1112
query-engine-metrics = { path = "../query-engine/metrics" }
1213

0 commit comments

Comments
 (0)