Fixed bug #69144 (strtr not replacing with partly matching replace pairs)

Author: laruence

ext/standard/string.c

@@ -3140,7 +3140,7 @@ static void php_strtr_array(zval *return_value, zend_string *input, HashTable *p
 			pos++;
 		}
 	}
-	if (result.s && result.s->len) {
+	if (result.s) {
 		smart_str_appendl(&result, str + old_pos, slen - old_pos);
 		smart_str_0(&result);
 		RETVAL_STR(result.s);

ext/standard/tests/strings/bug69144.phpt

@@ -0,0 +1,15 @@
+--TEST--
+Bug #69144 (strtr not replacing with partly matching replace pairs)
+--FILE--
+<?php
+$tests = array('bar' => '', 'foo' => 'o', 'foobar' => '', 'hello' => 'hello');
+
+foreach ($tests as $input => $expected) {
+    if ($expected !== ($actual = strtr($input, array("fo" => "", "foobar" => "", "bar" => "")))) {
+        echo "KO `$input` became `$actual` instead of `$expected`\n";
+    }
+}
+echo "okey";
+?>
+--EXPECT--
+okey