empty lines in inline diagnostics

[thegrubster]

Summary

I get some weird line showcasing empty lines with no diagnostic information on, as seen in the picture below. I am wondering if this is expected behaviour because of some rust-analyzer thing?

It is not like it is a big issue, but it does look somewhat weird. Is there someway to check of the diagnostic message is empty and then not draw the line perhaps?

Reproduction Steps

I added a new tuple field to an enum variant.

I have not been able to reproduce the rust-analyzer hint in minimal examples unfortunately.

Helix log

I can provide the log file, but it quite large (around 7 MB just from indexing the rust project, 10s~ of runtime).

Platform

NixOS 24.11pre681973.99dc8785f6a0 (Vicuna) x86_64

Terminal Emulator

alacritty 0.13.2 + zellij 0.40.1

Installation Method

flake

Helix Version

helix 24.7 (newer master build) revision 38e6fcd

[the-mikedavis]

This is probably an issue with the diagnostics that rust-analyzer produces. Can you search the log for a line that includes "publishDiagnostic" and also "tuple variant has 3 fields"? I expect that the message for the empty ones you see is empty in the publishDiagnostic notification. Filtering these out is probably not a good behavior - this should be fixed in the language server instead.

[thegrubster]

It seems you are right, at least there are multiple instances of the message being just a whitespace character. I included an example below.

Thanks for the fast feedback!

{
   "jsonrpc":"2.0",
   "method":"textDocument/publishDiagnostics",
   "params":{
      "uri":"file:///home/krath/Documents/kasm/src/instruction/mod.rs",
      "diagnostics":[
         {
            "range":{
               "start":{
                  "line":46,
                  "character":4
               },
               "end":{
                  "line":46,
                  "character":8
               }
            },
            "severity":4,
            "code":"E0061",
            "codeDescription":{
               "href":"https://doc.rust-lang.org/error-index.html#E0061"
            },
            "source":"rustc",
            "message":"tuple variant defined here",
            "relatedInformation":[
               {
                  "location":{
                     "uri":"file:///home/krath/Documents/kasm/src/decode/jump.rs",
                     "range":{
                        "start":{
                           "line":14,
                           "character":11
                        },
                        "end":{
                           "line":14,
                           "character":28
                        }
                     }
                  },
                  "message":"original diagnostic"
               }
            ]
         },
         {
            "range":{
               "start":{
                  "line":46,
                  "character":9
               },
               "end":{
                  "line":46,
                  "character":13
               }
            },
            "severity":4,
            "code":"E0023",
            "codeDescription":{
               "href":"https://doc.rust-lang.org/error-index.html#E0023"
            },
            "source":"rustc",
            "message":" ",
            "relatedInformation":[
               {
                  "location":{
                     "uri":"file:///home/krath/Documents/kasm/src/execute/mod.rs",
                     "range":{
                        "start":{
                           "line":43,
                           "character":40
                        },
                        "end":{
                           "line":43,
                           "character":47
                        }
                     }
                  },
                  "message":"original diagnostic"
               }
            ]
         },
         {
            "range":{
               "start":{
                  "line":46,
                  "character":15
               },
               "end":{
                  "line":46,
                  "character":28
               }
            },
            "severity":4,
            "code":"E0023",
            "codeDescription":{
               "href":"https://doc.rust-lang.org/error-index.html#E0023"
            },
            "source":"rustc",
            "message":" ",
            "relatedInformation":[
               {
                  "location":{
                     "uri":"file:///home/krath/Documents/kasm/src/execute/mod.rs",
                     "range":{
                        "start":{
                           "line":43,
                           "character":40
                        },
                        "end":{
                           "line":43,
                           "character":47
                        }
                     }
                  },
                  "message":"original diagnostic"
               }
            ]
         },
         {
            "range":{
               "start":{
                  "line":46,
                  "character":30
               },
               "end":{
                  "line":46,
                  "character":46
               }
            },
            "severity":4,
            "code":"E0023",
            "codeDescription":{
               "href":"https://doc.rust-lang.org/error-index.html#E0023"
            },
            "source":"rustc",
            "message":"tuple variant has 3 fields",
            "relatedInformation":[
               {
                  "location":{
                     "uri":"file:///home/krath/Documents/kasm/src/execute/mod.rs",
                     "range":{
                        "start":{
                           "line":43,
                           "character":40
                        },
                        "end":{
                           "line":43,
                           "character":47
                        }
                     }
                  },
                  "message":"original diagnostic"
               }
            ]
         }
      ],
      "version":0
   }
}