Cannot save a file.

[dam5h]

Summary

I have been running into an issue lately where the file will not save [+]. Usually its only for a second or so. Today its one file in particular that will not save and no matter how many times I kill helix and restart it I cannot save it. I freezes when I try to force quit :q! as well.

The only thing showing up in the log is something about helix_vcs with the diff computation timing out.

The git gutter does show up when I delete a line as expected, it just can't save. And I can use :reload and the file comes back to what it originally was, reverting my edit.

There are no other processes using this file.

Reproduction Steps

I tried this:

1. hx -v make_distribution.py

I expected to be able to edit and save the file.

Instead, this happened:

It will not save.

Helix log

~/.cache/helix/helix.log

2023-06-09T11:57:30.968 helix_lsp::transport [INFO] pyright-langserver <- {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/dave/code/gemini-skeleton/make_distribution.py","version":0,"diagnostics":[]}}
2023-06-09T11:57:33.626 helix_lsp::transport [INFO] pyright-langserver -> {"jsonrpc":"2.0","method":"shutdown","id":1}
2023-06-09T11:57:33.628 helix_lsp::transport [INFO] pyright-langserver <- {"jsonrpc":"2.0","id":1,"result":null}
2023-06-09T11:57:33.628 helix_lsp::transport [INFO] pyright-langserver <- null
2023-06-09T11:57:33.628 helix_lsp::transport [INFO] pyright-langserver -> {"jsonrpc":"2.0","method":"exit"}
2023-06-09T11:57:33.637 helix_lsp::transport [ERROR] pyright-langserver err: <- StreamClosed
2023-06-09T11:57:38.196 helix_vcs::diff::worker [INFO] Diff computation timed out, update of diffs might appear delayed
2023-06-09T11:57:56.431 helix_vcs [INFO] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/home/dave/.cache/helix",
        },
    ),
}
2023-06-09T11:57:56.431 helix_vcs [INFO] failed to open diff base for /home/dave/.cache/helix/helix.log
2023-06-09T11:57:56.431 helix_vcs [INFO] Error {
    context: "failed to open git repo",
    source: Discover(
        NoGitRepository {
            path: "/home/dave/.cache/helix",
        },
    ),
}
2023-06-09T11:57:56.431 helix_vcs [INFO] failed to obtain current head name for /home/dave/.cache/helix/helix.log
2023-06-09T11:58:57.916 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["make_distribution.py"]
2023-06-09T11:58:59.137 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["make_distribution.py"]

Platform

Linux

Terminal Emulator

kitty

Helix Version

helix 23.05 (00b152f)

[dam5h]

I just restarted the computer to ensure there were no other locks on the file and still have the same problem. Pretty strange. Is there an easy way to disable vcs?

I also tried turning off the lsp server prior to saving and it didn't matter, it still would not save.

[pascalkuthe]

the diff gutter has likely nothing to do with the saving issues. That file is just large/your CPU is slow.

The real problem is that your LSP SERVER crashed. Thelix runs autoformatting before saving so that's causing the save issuer and helix wii wait for all reverse to shutdown properly on exit(which a crashed server never can) so that's causing the freeze while quitting. I think older versions of pyright were buggy IIRC SO updating may help (or switching back to the default python LSP)

[dam5h]

Replied below, rather than clicking "Reply" did not realize how this Discussions forum worked...

Cheers,
Dave

[dam5h]

That file is just large/your CPU is slow.

The file is a tiny script, and my i7 is an 11th gen, not yet 2 years old so not slow by most standards.

It does make sense that the LSP would be the culprit, but that is also why I shut it down manually :lsp stop prior to editing the file. It seems like a bug if you cannot save a file because a 3rd party LSP crashed. Furthermore, I have to force stop helix as :quit doesn't work, even after :restore, same with :quit!.

I will upgrade pyright and see, but I have also seen this with rust files where I needed to wait a while for a save and was confused it didn't and thought I had missed hitting enter or something. It's actually one of the reasons I recently pulled.

I ran git bisect without any changes to pyright and identified this commit as the start of the issue:

71551d395b4e47804df2d8ecea99e34dbbf16157 is the first bad commit
commit 71551d395b4e47804df2d8ecea99e34dbbf16157
Author: Philipp Mildenberger <[email protected]>
Date:   Mon May 23 18:10:48 2022 +0200

    Adds support for multiple language servers per language.

Which I suppose makes sense given that it is LSP related, still think it's weird it happens after manually turning off lsp and that it causes helix to freeze indefinitely (seemingly).

Here is a video showing that even after using "undo" on the change it still cannot "quit" and needs to be force exited.

I will try updating pyright and report back. EDIT: using the latest pyright 1.1.313 this is still an issue.

simplescreenrecorder-2023-06-09_13.23.13.mp4

[gabydd]

hmm I am not able to reproduce this, what is your config for pyright + python?