Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunk loading config option #104

Open
jeremiahwinsley opened this issue Apr 1, 2022 · 3 comments
Open

Chunk loading config option #104

jeremiahwinsley opened this issue Apr 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jeremiahwinsley
Copy link

Bug description
When connected to pipes in unloaded chunks, (likely after some load/unload cycles) the fluid pipe loads chunks.

This was a universal pipe with an infinity upgrade.

See attached screenshot/link to Spark profile.

https://spark.lucko.me/0QHI3cu8zB

2022-04-01 10_56_00-Profile at 10_35AM 4_1_2022

From a quick look, it seems this could be fixed by checking whether the position is loaded first here:

TileEntity te = tileEntity.getLevel().getBlockEntity(pos);

The same issue is potentially present on other pipe types as well.

Versions

  • Minecraft version: 1.16.5
  • Forge version: 36.2.31
  • Mod version: 1.2.15

Other Mods
Modpack ATM6 1.8.22

@jeremiahwinsley jeremiahwinsley added the bug Something isn't working label Apr 1, 2022
@henkelmax
Copy link
Owner

It is completely intended that the end of a pipez line loads chunks.

@henkelmax henkelmax added wontfix This will not be worked on and removed bug Something isn't working labels Apr 1, 2022
@jeremiahwinsley
Copy link
Author

If loading chunks is the desired behavior, then the bug is that it does not keep them loaded, instead constantly loading and unloading them. As you can see from the spark profile, this results in performance issues.

That said, I would like to have configuration options for this behavior if possible. We have other mods that provide chunk loading and would like to limit the amount of loaded chunks.

@henkelmax
Copy link
Owner

Yeah, a config option might be appropriate.

@henkelmax henkelmax added enhancement New feature or request and removed wontfix This will not be worked on labels Apr 1, 2022
@henkelmax henkelmax changed the title [1.16.5] Fluid pipe loading chunks Chunk loading config option Apr 1, 2022
@henkelmax henkelmax reopened this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants