Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"As Seen" distribution mode #126

Open
Rseding91 opened this issue Jun 13, 2022 · 3 comments
Open

"As Seen" distribution mode #126

Rseding91 opened this issue Jun 13, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Rseding91
Copy link

Rseding91 commented Jun 13, 2022

Is your feature request related to a problem? Please describe.
I'm always trying to squeeze more performance out of modded Minecraft and I love Pipez for what it can do. However I don't need the order of items inserted to be nearest-first, furthest-first or in any specific order: I just want it to shove items into the connected inventories as fast as It can until it runs out of places to put things or items to shove.

Describe the solution you'd like
I'd like a "As Seen" or "As Connected" distribution mode that visits the connected inventories in what ever order the Pipez internal logic has them stored (no sorting required).

Describe alternatives you've considered
N/A

Additional context
I downloaded Pipez locally and made this change with minimal effort. For the maintainers I think this would take 10~ minutes to implement if even that. For reference this is the icon I went with:
image

@Rseding91 Rseding91 added the enhancement New feature or request label Jun 13, 2022
@henkelmax
Copy link
Owner

This would have no performance impact, as connections are always cached.

@henkelmax henkelmax closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2023
@Rseding91
Copy link
Author

The connections are cached; but the order they're provided to the insertion logic is not: https://github.com/henkelmax/pipez/blob/master/src/main/java/de/maxhenkel/pipez/blocks/tileentity/UpgradeTileEntity.java#L144 creates a new collection and sorts them every time the method is called.

@Rseding91
Copy link
Author

@henkelmax Can this be re-opened per my comment above? The code shows that the 'as seen' would avoid the extra collection and sort call which is not cached.

@henkelmax henkelmax reopened this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants