Skip to content

Commit 10f48c8

Browse files
henry40408claude
andauthored
fix(docker): bump cargo-zigbuild to 0.23.0 so the arm64 leg links again (#245)
The 1.98 toolchain bump (#241) is green on every CI check and still breaks the image: `docker.yml` fires on tags and pushes to `main`, not on pull requests, so the first build to run it was v0.30.1's — and only the arm64 leg failed. Rust 1.98 passes `--fix-cortex-a53-843419` to the linker for aarch64 targets (rust-lang/rust#155453). Zig's linker rejects unknown arguments outright, so the wrapper cargo-zigbuild 0.22.3 generates fails with `unsupported linker arg: --fix-cortex-a53-843419` and `noadd` never links for aarch64-unknown-linux-musl. amd64 is unaffected — the argument is only emitted for aarch64. cargo-zigbuild 0.23.0 filters the argument in `filter_linker_arg` (rust-cross/cargo-zigbuild#452), alongside the two other arguments it already dropped for the same reason. The rest of the 0.22.3..0.23.0 range is a cargo-dist config update, a cargo-options bump, and dependabot commits. Zig stays on 0.14.1: the fix is in the wrapper, not the linker, and 0.15+ still brings the libc++-19 bindgen requirement this pin exists to avoid. Claude-Session: https://claude.ai/code/session_01RLF7TP74kER7Wcx8Th33qc Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent e54a942 commit 10f48c8

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ RUN apt-get update \
1919

2020
# Zig 0.14.1 avoids the libc++-19 bindgen requirement that 0.15+ introduces.
2121
ARG ZIG_VERSION=0.14.1
22-
ARG ZIGBUILD_VERSION=0.22.3
22+
# 0.23.0 or newer: Rust 1.98 passes `--fix-cortex-a53-843419` to the linker on
23+
# aarch64, which zig's does not accept. cargo-zigbuild filters it out as of
24+
# rust-cross/cargo-zigbuild#452 — without that the arm64 leg fails to link.
25+
ARG ZIGBUILD_VERSION=0.23.0
2326
RUN cargo install cargo-zigbuild --version "${ZIGBUILD_VERSION}" --locked
2427
RUN set -eux; \
2528
case "$(uname -m)" in \

0 commit comments

Comments
 (0)