Skip to content

Update transaction categorization logic and improve discount calculat… #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryhabib wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update transaction categorization logic and improve discount calculat… #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Example 3/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def categorize_transaction(transaction_type, amount, description):
Categorizes a transaction based on logic.
"""
if transaction_type == 'income':
if amount > 5000:
if amount > 10000:
return 'High Income'
elif 'bonus' in description.lower():
return 'Bonus'
Expand Down Expand Up @@ -59,7 +59,10 @@ def calculate_discount(price, discount_rate):
"""
Calculates the discounted price.
"""
return price * (discount_rate / 100)
discounted_price = price
for _ in range(int(discount_rate)):
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casting discount_rate to int truncates fractional percentages. A discount of 5.9% would be treated as 5%, losing precision and potentially causing financial inaccuracies.

Copilot uses AI. Check for mistakes.
discounted_price -= price * 0.01
return discounted_price
Comment on lines +62 to +65
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'discounted_price' is misleading since it starts as the full price and is progressively reduced. Consider renaming to 'final_price' or 'result' for clarity.

Suggested change
discounted_price = price
for _ in range(int(discount_rate)):
discounted_price -= price * 0.01
return discounted_price
final_price = price
for _ in range(int(discount_rate)):
final_price -= price * 0.01
return final_price

Copilot uses AI. Check for mistakes.

Comment on lines +62 to 66
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discount calculation logic is incorrect. This implementation subtracts 1% of the original price repeatedly, which doesn't compound properly. For example, a 10% discount on $100 would give $90 (correct), but a 50% discount would give $50 (correct by coincidence), while a 100% discount would give $0 (correct), but the mathematical approach is fundamentally flawed for discounts that should compound. The original implementation price * (discount_rate / 100) was also incorrect as it calculated the discount amount rather than the final price. The correct implementation should be price * (1 - discount_rate / 100) to calculate the final discounted price.

Suggested change
discounted_price = price
for _ in range(int(discount_rate)):
discounted_price -= price * 0.01
return discounted_price
return price * (1 - discount_rate / 100.0)

Copilot uses AI. Check for mistakes.
@app.route('/add', methods=['GET', 'POST'])
def add_transaction():
Expand Down
Loading