Skip to content

Commit a278bc3

Browse files
aloiretfredemmott
authored andcommitted
Add type hints to lambda parameters. (#115)
Summary: required for .hhconfig disallow_ambiguous_lambda. Signed-off-by: Arthur Loiret <[email protected]>
1 parent 6880927 commit a278bc3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/CodegenFile.hack

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ final class CodegenFile {
400400
$this->fileNamespace ?? '',
401401
);
402402

403-
$get_use_statement = ($type, $ns, $as) ==>
403+
$get_use_statement = (string $type, string $ns, ?string $as) ==>
404404
\sprintf('use %s %s%s;', $type, $ns, $as === null ? '' : ' as '.$as);
405405

406406
foreach ($this->useNamespaces as $ns => $as) {

tests/HackBuilderTest.hack

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
namespace Facebook\HackCodegen;
1111

12+
use namespace HH\Lib\Regex;
13+
1214
final class HackBuilderTest extends CodegenBaseTest {
1315

1416
private function getHackBuilder(): HackBuilder {
@@ -78,7 +80,7 @@ final class HackBuilderTest extends CodegenBaseTest {
7880
}
7981

8082
public function testRegex(): void {
81-
$make_code = $re ==> $this->getHackBuilder()
83+
$make_code = (Regex\Pattern<Regex\Match> $re) ==> $this->getHackBuilder()
8284
->addValue($re, HackBuilderValues::regex())
8385
->getCode();
8486
expect($make_code(re"/foo/"))->toBeSame('re"/foo/"');

0 commit comments

Comments
 (0)