Skip to content

Commit 5083b8f

Browse files
committed
refactor: flip browser and ssr build
1 parent 7780ff5 commit 5083b8f

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

packages/react-server/examples/basic/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"type": "module",
66
"scripts": {
77
"dev": "vite dev",
8-
"build": "vite build",
8+
"build": "vite build --ssr",
99
"preview": "vite preview",
1010
"test-e2e": "playwright test",
1111
"test-e2e-preview": "E2E_PREVIEW=1 playwright test",

packages/react-server/examples/starter/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"type": "module",
66
"scripts": {
77
"dev": "vite dev",
8-
"build": "vite build",
8+
"build": "vite build --ssr",
99
"preview": "vite preview",
1010
"cf-build": "SSR_ENTRY=/src/adapters/cloudflare-workers.ts pnpm build && bash misc/cloudflare-workers/build.sh",
1111
"cf-preview": "cd misc/cloudflare-workers && wrangler dev",

packages/react-server/src/plugin/index.ts

+5-11
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ export function vitePluginReactServer(options?: {
289289
},
290290
};
291291

292-
// orchestrate four builds from a single vite (browser) build
292+
// orchestrate four builds from a single vite (ssr) build
293293
const buildOrchestrationPlugin: Plugin = {
294294
name: vitePluginReactServer.name + ":build",
295295
apply: "build",
@@ -298,24 +298,18 @@ export function vitePluginReactServer(options?: {
298298
console.log("▶▶▶ REACT SERVER BUILD (scan) [1/4]");
299299
manager.buildType = "scan";
300300
await build(reactServerViteConfig);
301+
301302
console.log("▶▶▶ REACT SERVER BUILD (server) [2/4]");
302303
manager.buildType = "rsc";
303304
manager.rscUseClientIds.clear();
304305
await build(reactServerViteConfig);
306+
305307
console.log("▶▶▶ REACT SERVER BUILD (browser) [3/4]");
306308
manager.buildType = "client";
307-
}
308-
},
309-
async closeBundle() {
310-
// TODO: build ssr only when client build succeeds
311-
if (manager.buildType === "client") {
309+
await build();
310+
312311
console.log("▶▶▶ REACT SERVER BUILD (ssr) [4/4]");
313312
manager.buildType = "ssr";
314-
await build({
315-
build: {
316-
ssr: true,
317-
},
318-
});
319313
}
320314
},
321315
};

0 commit comments

Comments
 (0)