[6.6] HHH-19910 EntityInitializer#resolveInstance wrongly initializes existing detached instance #11219
+1,891
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
beikov
approved these changes
Nov 11, 2025
.../main/java/org/hibernate/sql/results/graph/entity/internal/EntitySelectFetchInitializer.java
Outdated
Show resolved
Hide resolved
.../main/java/org/hibernate/sql/results/graph/entity/internal/EntitySelectFetchInitializer.java
Outdated
Show resolved
Hide resolved
...g/hibernate/sql/results/graph/entity/internal/AbstractBatchEntitySelectFetchInitializer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/sql/results/graph/entity/internal/DiscriminatedEntityInitializer.java
Outdated
Show resolved
Hide resolved
...main/java/org/hibernate/sql/results/graph/entity/internal/EntityDelayedFetchInitializer.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Show resolved
Hide resolved
mbellade
force-pushed
the
initialize-detached
branch
from
cc31533 to
e9b6ef7
Compare
beikov
requested changes
Nov 12, 2025
...g/hibernate/sql/results/graph/entity/internal/AbstractBatchEntitySelectFetchInitializer.java
Outdated
Show resolved
Hide resolved
...ain/java/org/hibernate/sql/results/graph/entity/internal/DiscriminatedEntityInitializer.java
Outdated
Show resolved
Hide resolved
...main/java/org/hibernate/sql/results/graph/entity/internal/EntityDelayedFetchInitializer.java
Outdated
Show resolved
Hide resolved
.../main/java/org/hibernate/sql/results/graph/entity/internal/EntitySelectFetchInitializer.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Show resolved
Hide resolved
beikov
reviewed
Nov 12, 2025
...ore/src/main/java/org/hibernate/sql/results/graph/entity/internal/EntityInitializerImpl.java
Outdated
Show resolved
Hide resolved
mbellade
force-pushed
the
initialize-detached
branch
from
e9b6ef7 to
b4b95fa
Compare
beikov
reviewed
Nov 12, 2025
...ain/java/org/hibernate/sql/results/graph/entity/internal/DiscriminatedEntityInitializer.java
Show resolved
Hide resolved
beikov
reviewed
Nov 12, 2025
...g/hibernate/sql/results/graph/entity/internal/AbstractBatchEntitySelectFetchInitializer.java
Show resolved
Hide resolved
beikov
reviewed
Nov 12, 2025
...g/hibernate/sql/results/graph/entity/internal/AbstractBatchEntitySelectFetchInitializer.java
Show resolved
Hide resolved
mbellade
force-pushed
the
initialize-detached
branch
from
b4b95fa to
95ddb93
Compare
mbellade
force-pushed
the
initialize-detached
branch
from
95ddb93 to
e188e6d
Compare
beikov
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19910
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.