Skip to content

[#1673] Check the generated SQL in CustomOneToOneStoredProcedureSqlT #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Nesrinasan
Copy link

add test storeProsedure using hibernate @SqlInsert and @SqlDelete annotation

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jul 18, 2023

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@Nesrinasan Nesrinasan changed the title [#1673] Check the generated SQL in CustomOneToOneStoredProcedureSqlT… [#1673] Check the generated SQL in CustomOneToOneStoredProcedureSqlT Jul 18, 2023
@DavideD
Copy link
Member

DavideD commented Jul 20, 2023

Thanks, but I don't understand the difference between this test and the one we already have. Am I missing something?

@Nesrinasan
Copy link
Author

Hi @DavideD
Actually, I wanted to write a test for onetoone relationship. here is a test of the relationship between two tables and those tables. Did I misunderstand what you wanted? can you give me an example

@DavideD
Copy link
Member

DavideD commented Jul 25, 2023

My idea was to have something similar to SQLSelectTest. Where we actually check that the query has been executed.

I didn't think of the use case where there is an association, but I guess it's a good idea to have this test case.

@DavideD
Copy link
Member

DavideD commented Jul 26, 2023

Merged, with a change to the commit message

@DavideD DavideD closed this Jul 26, 2023
@DavideD
Copy link
Member

DavideD commented Jul 26, 2023

Thanks a lot!

@DavideD DavideD reopened this Jul 26, 2023
@DavideD DavideD closed this Jul 26, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this pull request Aug 28, 2023
DavideD added a commit to DavideD/hibernate-reactive that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that we actually run the custom queries in CustomStoredProcedureSqlTest
2 participants