Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test upsert with inheritance #1766

Open
DavideD opened this issue Sep 15, 2023 · 4 comments
Open

Test upsert with inheritance #1766

DavideD opened this issue Sep 15, 2023 · 4 comments
Labels
good first issue Good for newcomers testing Improvements to test suite

Comments

@DavideD
Copy link
Member

DavideD commented Sep 15, 2023

We only test the upsert for ReactiveSingleTableEntityPersister, but it's also implemented for ReactiveUnionSubclassEntityPersister and ReactiveJoinedSubclassEntityPersister

We should also test the deletion of rows with upsert works (currently we only test the update)
Related to issue #1702

@DavideD DavideD added testing Improvements to test suite good first issue Good for newcomers labels Sep 15, 2023
@firatulgay
Copy link

Hello,

I want to work on this issue. I found the UpsertTest.java class which contains the upsert tests already. I will check this class for a reference. But I didnt get exactly what do you mean here "deletion of rows with upsert works". Can you help me on this please.

@DavideD
Copy link
Member Author

DavideD commented Oct 31, 2023

Hello,
forget about the delete. When I created the issue I thought there was a way to also do that.

Thanks a lot for the offer.

If you create the test and it doesn't work, make sure to sync with @blafond before applying changes to the main code.
He's working on something related to this.

As far as contribution guides, we use the same as the ORM one: https://github.com/hibernate/hibernate-orm/blob/main/CONTRIBUTING.md

Thanks a lot

@coder-github578
Copy link

Hey David,

Is there any sample example for upsert

@DavideD
Copy link
Member Author

DavideD commented Nov 21, 2024

You can check this test:

test( context, getMutinySessionFactory().withStatelessTransaction( ss -> ss

@DavideD DavideD added problem A limitation or source of discomfort and removed problem A limitation or source of discomfort labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Improvements to test suite
Projects
None yet
Development

No branches or pull requests

3 participants