Skip to content

Commit 69de3d7

Browse files
committed
fix: Resolve compilation warnings related to Javadoc formatting and comment placement
Addresses issue #20719 by fixing multiple categories of compiler warnings: - Standardized comment separator formatting to comply with style guidelines - Repositioned annotations to appear after Javadoc comments per Java best practices - Corrected typos in documentation comments - Removed incomplete or orphaned comment fragments
1 parent ff52a27 commit 69de3d7

File tree

18 files changed

+48
-51
lines changed

18 files changed

+48
-51
lines changed

hedera-node/hapi-utils/src/test/java/com/hedera/node/app/hapi/utils/keys/KeyComparatorTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ void verifyUnsupportedTypes(final String caseName, final Key lValue, final Key r
7575
.isInstanceOf(UnsupportedOperationException.class);
7676
}
7777

78-
////////////////////////////////////////////////////////////////////////////////////////////////
79-
// Parameterized test method sources //
80-
////////////////////////////////////////////////////////////////////////////////////////////////
78+
// ----------------------------------------------------------------------------------------------------
79+
// Parameterized test method sources
80+
// ----------------------------------------------------------------------------------------------------
8181
public static Stream<Arguments> generateAllCrossTypeMatches() {
8282
final Integer zero = Integer.valueOf(0);
8383
final Integer one = Integer.valueOf(1);
@@ -508,9 +508,9 @@ private static void delegateIdCases(final List<Arguments> result) {
508508
addDelegateId(result, minusOne, new IdVal("0.1.one", 0, 0, 1, -1), new IdVal("0.2.five", 4, 0, 2, -1));
509509
}
510510

511-
////////////////////////////////////////////////////////////////////////////////////////////////
512-
// Supporting methods and record types //
513-
////////////////////////////////////////////////////////////////////////////////////////////////
511+
// ----------------------------------------------------------------------------------------------------
512+
// Supporting methods and record types
513+
// ----------------------------------------------------------------------------------------------------
514514
private static record IdVal(String name, int index, int realm, int shard, int num) {}
515515

516516
private static record NamedKeyList(String name, Key key) {}
@@ -540,9 +540,9 @@ private static Key modifyId(
540540
else return Key.newBuilder().contractID(builder).build();
541541
}
542542

543-
////////////////////////////////////////////////////////////////////////////////////////////////
544-
// Static data fragments //
545-
////////////////////////////////////////////////////////////////////////////////////////////////
543+
// ----------------------------------------------------------------------------------------------------
544+
// Static data fragments
545+
// ----------------------------------------------------------------------------------------------------
546546
// Test ECDSA SECP256 K1 key hex values
547547
private static final Bytes[] ECDSA_BYTES = {
548548
Bytes.fromHex("00badcadfaddad2bedfedbeef959feedbeadcafecadecedebeed4acedecada5ada"),

hedera-node/hedera-app/src/main/java/com/hedera/node/app/records/impl/producers/formats/v6/BlockRecordWriterV6.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ private enum State {
7474
private final Signer signer;
7575
/** The maximum size of a sidecar file in bytes. */
7676
private final int maxSideCarSizeInBytes;
77-
/** Whether to compress the record file and sidecar files. */
7877
/** The node-specific path to the directory where record files are written */
7978
private final Path nodeScopedRecordDir;
8079
/**

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/opcodes/SStoreSuite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@
3535
import org.junit.jupiter.api.DynamicTest;
3636
import org.junit.jupiter.api.Tag;
3737

38-
@Tag(SMART_CONTRACT)
3938
/** - CONCURRENCY STATUS - . Can run concurrent without temporarySStoreRefundTest() */
39+
@Tag(SMART_CONTRACT)
4040
public class SStoreSuite {
4141

4242
private static final Logger log = LogManager.getLogger(SStoreSuite.class);

hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/token/batch/AtomicTokenCreateSpecs.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,14 @@
105105

106106
// This test cases are direct copies of TokenCreateSpecs. The difference here is that
107107
// we are wrapping the operations in an atomic batch to confirm that everything works as expected.
108-
@HapiTestLifecycle
109108
/**
110109
* Validates the {@code TokenCreate} transaction, including its:
111110
* <ul>
112111
* <li>Auto-association behavior.</li>
113112
* <li>Default values.</li>
114113
* </ul>
115114
*/
115+
@HapiTestLifecycle
116116
@Tag(TOKEN)
117117
class AtomicTokenCreateSpecs {
118118

platform-sdk/platform-apps/demos/StatsDemo/src/main/java/com/swirlds/demo/stats/StatsDemoMain.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public StatsDemoMain() {
8888
.build();
8989
}
9090

91-
/////////////////////////////////////////////////////////////////////
91+
// ----------------------------------------------------------------------------------------------------
9292
/** the time of the last call to preEvent */
9393
long lastEventTime = System.nanoTime();
9494
/** number of events needed to be created (the non-integer leftover from last preEvent call */

platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/PayloadDistribution.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class PayloadDistribution {
2626
private PAYLOAD_TYPE[] typeDistribution;
2727
private int[] sizeDistribution;
2828
private float[] ratioDistribution;
29-
/** probability of payload distribution, sum of array should be 100 */
29+
// probability of payload distribution, sum of array should be 100
3030

3131
// private PayloadDistribution(Builder builder) {
3232
// this.typeDistribution = builder.typeDistribution;

platform-sdk/platform-apps/tests/PlatformTestingTool/src/main/java/com/swirlds/demo/platform/TransactionSubmitter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,16 @@ public static SUBMIT_GOAL fromOrdinal(int n) {
9090
float c2cLatencySecond = 3;
9191

9292
/**
93-
* track statistics to achive system goal
93+
* track statistics to achieve system goal
9494
*/
9595
long accumulatedBytes = 0;
9696

9797
long accumulatedTrans = 0;
9898
long accumulatedEvent = 0;
9999
long accumulatedRound = 0;
100100

101-
long cycleStartMS = 0;
102101
/** cycle start time in millisecond unit */
102+
long cycleStartMS = 0;
103103

104104
/**
105105
* pause submission after certain amount of transaction

platform-sdk/swirlds-benchmarks/src/jmh/java/com/swirlds/benchmark/reconnect/StateBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
* A utility class to help build random states.
1515
*/
1616
public record StateBuilder(
17-
/** Build a key for index 1..size. */
17+
// Build a key for index 1..size.
1818
Function<Long, Bytes> keyBuilder,
19-
/** Build a value for key index 1..size. */
19+
// Build a value for key index 1..size.
2020
Function<Long, BenchmarkValue> valueBuilder) {
2121

2222
/** Return {@code true} with the given probability. */

platform-sdk/swirlds-fcqueue/src/main/java/com/swirlds/fcqueue/FCQueue.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,9 @@ public boolean isSelfHashing() {
244244
return true;
245245
}
246246

247-
//////////////////////////////////////////////////////////////////////////////////////////////////
247+
// ----------------------------------------------------------------------------------------------------
248248
// the following implement Queue<E>
249-
//////////////////////////////////////////////////////////////////////////////////////////////////
249+
// ----------------------------------------------------------------------------------------------------
250250

251251
/**
252252
* Inserts the specified element into this queue if it is possible to do so
@@ -392,9 +392,9 @@ public synchronized E peek() {
392392
return head.element;
393393
}
394394

395-
//////////////////////////////////////////////////////////////////////////////////////////////////
395+
// ----------------------------------------------------------------------------------------------------
396396
// the following implement FastCopyable
397-
//////////////////////////////////////////////////////////////////////////////////////////////////
397+
// ----------------------------------------------------------------------------------------------------
398398

399399
/** {@inheritDoc} */
400400
@Override
@@ -411,9 +411,9 @@ public synchronized FCQueue<E> copy() {
411411
return queue;
412412
}
413413

414-
//////////////////////////////////////////////////////////////////////////////////////////////////
414+
// ----------------------------------------------------------------------------------------------------
415415
// the following implement AbstractMerkleNode
416-
//////////////////////////////////////////////////////////////////////////////////////////////////
416+
// ----------------------------------------------------------------------------------------------------
417417

418418
@Override
419419
protected synchronized void destroyNode() {
@@ -423,9 +423,9 @@ protected synchronized void destroyNode() {
423423
hash = NULL_HASH;
424424
}
425425

426-
//////////////////////////////////////////////////////////////////////////////////////////////////
426+
// ----------------------------------------------------------------------------------------------------
427427
// the following implement Java.util.Collection
428-
//////////////////////////////////////////////////////////////////////////////////////////////////
428+
// ----------------------------------------------------------------------------------------------------
429429

430430
/**
431431
* Returns the number of elements in this collection.
@@ -717,9 +717,9 @@ public synchronized void clear() {
717717
hash = null;
718718
}
719719

720-
//////////////////////////////////////////////////////////////////////////////////////////////////
720+
// ----------------------------------------------------------------------------------------------------
721721
// the following FastCopyable methods have default implementations, but are overridden here
722-
//////////////////////////////////////////////////////////////////////////////////////////////////
722+
// ----------------------------------------------------------------------------------------------------
723723

724724
@Override
725725
public boolean equals(final Object o) {

platform-sdk/swirlds-fcqueue/src/test/java/com/swirlds/fcqueue/MockFCQueue.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ public Hash getHash() {
8282
} // sync
8383
}
8484

85-
//////////////////////////////////////////////////////////////////////////////////////////////////
85+
// ----------------------------------------------------------------------------------------------------
8686
// the following implement Queue<E>
87-
//////////////////////////////////////////////////////////////////////////////////////////////////
87+
// ----------------------------------------------------------------------------------------------------
8888

8989
/**
9090
* Inserts the specified element into this queue if it is possible to do so
@@ -280,9 +280,9 @@ public E remove() {
280280
}
281281
}
282282

283-
//////////////////////////////////////////////////////////////////////////////////////////////////
283+
// ----------------------------------------------------------------------------------------------------
284284
// the following implement FastCopyable
285-
//////////////////////////////////////////////////////////////////////////////////////////////////
285+
// ----------------------------------------------------------------------------------------------------
286286

287287
/** {@inheritDoc} */
288288
@Override

0 commit comments

Comments
 (0)