test: Implement additional HAPI tests for node account id updates #21916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eva <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Eva <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21916 +/- ##
=========================================
Coverage 70.82% 70.82%
- Complexity 24397 24398 +1
=========================================
Files 2667 2667
Lines 104233 104233
Branches 10948 10948
=========================================
+ Hits 73825 73826 +1
Misses 26359 26359
+ Partials 4049 4048 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
ibankov
approved these changes
Oct 31, 2025
Contributor
ibankov
left a comment
ibankov
left a comment
There was a problem hiding this comment.
LGTM, ty @Evdokia-Georgieva
Evdokia-Georgieva
deleted the
hip-1299-node-account-id-additional-tests
branch
petreze
pushed a commit
that referenced
this pull request
Nov 3, 2025
…1916) Signed-off-by: Eva <[email protected]> Signed-off-by: Petar Tonev <[email protected]>
mxtartaglia-sl
pushed a commit
that referenced
this pull request
Nov 3, 2025
…1916) Signed-off-by: Eva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR contains additional HAPI tests for node account id updates.
Related issue(s):
#21375