Skip to content

Conversation

@netopyr
Copy link
Contributor

@netopyr netopyr commented Nov 1, 2025

Description:

This PR adds out-of-the-box profiling support to Otter.

The Node interface has new methods startProfiling() and stopProfiling(), which start and stop a profiler of a node in the container environment. Once profiling is complete, the generated file is uploaded to the host machine.

Related issue(s):

Fixes #21944

Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
@netopyr netopyr added this to the v0.68 milestone Nov 1, 2025
@netopyr netopyr requested review from poulok and timo0 November 1, 2025 08:46
@lfdt-bot
Copy link

lfdt-bot commented Nov 1, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #21963   +/-   ##
=========================================
  Coverage     70.94%   70.94%           
  Complexity    24432    24432           
=========================================
  Files          2668     2668           
  Lines        104336   104336           
  Branches      10955    10955           
=========================================
  Hits          74019    74019           
  Misses        26274    26274           
  Partials       4043     4043           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codacy-production
Copy link

codacy-production bot commented Nov 1, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c563e7) 104241 78017 74.84%
Head commit (cd3797e) 104241 (+0) 78017 (+0) 74.84% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#21963) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@netopyr netopyr self-assigned this Nov 1, 2025
@abies
Copy link
Contributor

abies commented Nov 3, 2025

Change looks good overall.

# Conflicts:
#	platform-sdk/consensus-otter-tests/src/testFixtures/java/org/hiero/otter/fixtures/container/ContainerNode.java
Signed-off-by: Michael Heinrichs <[email protected]>
Signed-off-by: Michael Heinrichs <[email protected]>
@netopyr netopyr marked this pull request as ready for review November 6, 2025 14:27
@netopyr netopyr requested a review from a team as a code owner November 6, 2025 14:27
@poulok poulok merged commit e266aa3 into main Nov 10, 2025
62 of 63 checks passed
@poulok poulok deleted the 21944-integrated-profiling branch November 10, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrated profiling support

5 participants