From 817de197d534c58a7bcf3dd55a1e76f4b107ae72 Mon Sep 17 00:00:00 2001 From: JP Simard Date: Mon, 24 Apr 2023 15:13:44 -0400 Subject: [PATCH] Clean up `MARK` comments --- .../Rules/Idiomatic/DiscouragedAssertRule.swift | 6 ------ .../Rules/Lint/BalancedXCTestLifecycleRule.swift | 10 ++-------- .../Rules/Lint/PrivateSubjectRule.swift | 6 ------ 3 files changed, 2 insertions(+), 20 deletions(-) diff --git a/Source/SwiftLintFramework/Rules/Idiomatic/DiscouragedAssertRule.swift b/Source/SwiftLintFramework/Rules/Idiomatic/DiscouragedAssertRule.swift index 72d5bb559e..a17bfc33c5 100644 --- a/Source/SwiftLintFramework/Rules/Idiomatic/DiscouragedAssertRule.swift +++ b/Source/SwiftLintFramework/Rules/Idiomatic/DiscouragedAssertRule.swift @@ -1,8 +1,6 @@ import SwiftSyntax struct DiscouragedAssertRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRule { - // MARK: - Properties - var configuration = SeverityConfiguration(.warning) static let description = RuleDescription( @@ -25,10 +23,6 @@ struct DiscouragedAssertRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderR ] ) - // MARK: - Life cycle - - // MARK: - Public - func makeVisitor(file: SwiftLintFile) -> ViolationsSyntaxVisitor { Visitor(viewMode: .sourceAccurate) } diff --git a/Source/SwiftLintFramework/Rules/Lint/BalancedXCTestLifecycleRule.swift b/Source/SwiftLintFramework/Rules/Lint/BalancedXCTestLifecycleRule.swift index b530beb0cb..ee0e66b2e3 100644 --- a/Source/SwiftLintFramework/Rules/Lint/BalancedXCTestLifecycleRule.swift +++ b/Source/SwiftLintFramework/Rules/Lint/BalancedXCTestLifecycleRule.swift @@ -1,8 +1,6 @@ import SwiftSyntax struct BalancedXCTestLifecycleRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRule { - // MARK: - Properties - var configuration = BalancedXCTestLifecycleConfiguration() static let description = RuleDescription( @@ -106,15 +104,13 @@ struct BalancedXCTestLifecycleRule: SwiftSyntaxRule, OptInRule, ConfigurationPro ] ) - // MARK: - Life cycle - - // MARK: - Public - func makeVisitor(file: SwiftLintFile) -> ViolationsSyntaxVisitor { Visitor(viewMode: .sourceAccurate, testParentClasses: configuration.testParentClasses) } } +// MARK: - Private + private extension BalancedXCTestLifecycleRule { final class Visitor: ViolationsSyntaxVisitor { private let testParentClasses: Set @@ -153,8 +149,6 @@ private extension BalancedXCTestLifecycleRule { } } -// MARK: - Private - private enum XCTMethod { case setUp case tearDown diff --git a/Source/SwiftLintFramework/Rules/Lint/PrivateSubjectRule.swift b/Source/SwiftLintFramework/Rules/Lint/PrivateSubjectRule.swift index cce7846285..ede08ce3e3 100644 --- a/Source/SwiftLintFramework/Rules/Lint/PrivateSubjectRule.swift +++ b/Source/SwiftLintFramework/Rules/Lint/PrivateSubjectRule.swift @@ -1,8 +1,6 @@ import SwiftSyntax struct PrivateSubjectRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRule { - // MARK: - Properties - var configuration = SeverityConfiguration(.warning) static let description = RuleDescription( @@ -14,10 +12,6 @@ struct PrivateSubjectRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRule triggeringExamples: PrivateSubjectRuleExamples.triggeringExamples ) - // MARK: - Life cycle - - // MARK: - Public - func makeVisitor(file: SwiftLintFile) -> ViolationsSyntaxVisitor { Visitor(viewMode: .sourceAccurate) }