qa: Add wait_for_debugger param for node (re)starts

Enables tweaking functional tests to start debugging a specific node run/execution.

Author: hodlinator

test/functional/test_framework/test_framework.py

@@ -551,16 +551,16 @@ def stop_nodes(self, wait=0):
             # Wait for nodes to stop
             node.wait_until_stopped()
 
-    def restart_node(self, i, extra_args=None, clear_addrman=False, *, expected_stderr=''):
+    def restart_node(self, i, extra_args=None, clear_addrman=False, *, expected_stderr='', **kwargs):
         """Stop and start a test node"""
         self.stop_node(i, expected_stderr=expected_stderr)
         if clear_addrman:
             peers_dat = self.nodes[i].chain_path / "peers.dat"
             os.remove(peers_dat)
             with self.nodes[i].assert_debug_log(expected_msgs=[f'Creating peers.dat because the file was not found ("{peers_dat}")']):
-                self.start_node(i, extra_args)
+                self.start_node(i, extra_args, **kwargs)
         else:
-            self.start_node(i, extra_args)
+            self.start_node(i, extra_args, **kwargs)
 
     def wait_for_node_exit(self, i, timeout):
         self.nodes[i].process.wait(timeout)

test/functional/test_framework/test_node.py

@@ -249,7 +249,7 @@ def __getattr__(self, name):
             assert self.rpc_connected and self._rpc is not None, self._node_msg("Error: no RPC connection")
             return getattr(self._rpc, name)
 
-    def start(self, extra_args=None, *, cwd=None, stdout=None, stderr=None, env=None, **kwargs):
+    def start(self, extra_args=None, *, cwd=None, stdout=None, stderr=None, env=None, wait_for_debugger=False, **kwargs):
         """Start the node."""
         if extra_args is None:
             extra_args = self.extra_args
@@ -287,7 +287,7 @@ def start(self, extra_args=None, *, cwd=None, stdout=None, stderr=None, env=None
         if env is not None:
             subp_env.update(env)
 
-        wait_for_debugger = TestNode.run in TestNode.debug_runs
+        wait_for_debugger = wait_for_debugger or TestNode.run in TestNode.debug_runs
         if wait_for_debugger:
             extra_args.append("-waitfordebugger")
             # Allow human to context switch away, take time to attach debugger and/or debug init phase for 2 hours